When I use Webform (3.18 or 4 alpha 06), I get these warnings when I show a submission.
Seems to be related to multipage forms.

Notice: Undefined property: stdClass::$delta in homebox_forms() (Zeile 202 von ...sites/all/modules/homebox/homebox.module).
CommentFileSizeAuthor
#5 homebox-hook_forms-1893982-5.patch1.08 KBmaximpodorov
#2 homebox-hook_forms-1893982-1.patch1.04 KBchaby

Comments

chrbak’s picture

chrbak commented

I have the same issue. Altering the line 202 with the bellow solved my problem:
case isset($args[1]) && is_object($args[1]) && isset($args[1]->delta) ? 'homebox_block_edit_' . $args[1]->module . '_' . $args[1]->delta . '_form' : NULL:

chaby’s picture

chaby commented
Status: Active » Needs review
StatusFileSize
new homebox-hook_forms-1893982-1.patch1.04 KB

Same issue, here is a patch to avoid conflict with other modules

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

This looks like a good improvement. Works fine on simplytest.me.

amirtaiar’s picture

amirtaiar commented

Works fine for me with Mailchimp block.
Thank you.

maximpodorov’s picture

maximpodorov commented
Version: 7.x-2.0-beta6 » 7.x-2.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new homebox-hook_forms-1893982-5.patch1.08 KB

This patch is for current dev version which already checks delta existence. So the patch doesn't adds more checks, but makes the code not so ugly.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed

Committed with a small change, the second if can be an elseif.

  • drumm committed a815e77 on 7.x-2.x authored by maximpodorov 
    Issue #1893982 by chaby, maximpodorov: Make homebox_forms() more...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.