Use EntityListController for vocabularies

Also #1891746: Make vocabulary label in administrative listing link to its list of terms

Don't mind the failures on -2, -3, and -4 ... I'm just doing some pruning to shorten up the queue. If you did want independent results from the previous patches, feel free to re-test.

Looks good. One major problem though, this adds a new operation, "Disable" to the dropbutton.

@@ -0,0 +1,163 @@
+<?php
+
+/**
+ * Contains \Drupal\taxonomy\VocabularyListController.
+ */

Missing @file.

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Tests/VocabularyTest.phpundefined
@@ -93,7 +93,7 @@ function testTaxonomyAdminChangingWeights() {
-    $this->drupalPost('admin/structure/taxonomy', $edit, t('Save'));
+    $this->drupalPost('admin/structure/taxonomy', $edit, t('Save order'));

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/VocabularyListController.phpundefined
@@ -0,0 +1,164 @@
+      '#value' => t('Save order'),

+++ b/core/modules/taxonomy/taxonomy.admin.incundefined
@@ -9,88 +9,6 @@
-    $form['actions']['submit'] = array('#type' => 'submit', '#value' => t('Save'), '#button_type' => 'primary');

Why are you changing this string in a conversion issue?

Thanks!

This still has the "Disable" link in the dropbutton.

@twistor please open an issue to fix that generically, those should not be added unless the ConfigEntity defines a status entity_key.

Nevermind, I opened it.
#1994910: ConfigEntity listing should only show enable/disable if status is supported

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/VocabularyListController.phpundefined
@@ -0,0 +1,164 @@
+    if (count($entities) > 1) {
+      return drupal_get_form($this);
+    }

This looks unnecessary... and if it is... it certainly needs a comment. I've tested the code without this and it works as expected.

So this adds the ability to drag the rows around to order the weight...

// Creates a form for manipulating vocabulary weights.

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/Core/Entity/Vocabulary.phpundefined
@@ -29,7 +30,8 @@
+ *     "uuid" = "uuid",

I think , shouldn't be here.

I think , shouldn't be here.

On the contrary, it should. This is not JavaScript :) The correct patch is the one from #23.

Oh, that was in the annotation? Sorry @jibran, my bad :/

#25 looks good for me
lets make it commited

Committed 4370959 and pushed to 8.x. Thanks!