Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Follow-up task from #1552396: Convert vocabularies into configuration
As #1855402: Add generic weighting (tabledrag) support for config entities (DraggableListController) the sortable list of vocabularies could be easily implemented
This should remove theme_taxonomy_overview_vocabularies() function
related issues
#1938932: Remove taxonomy_overview_terms() and taxonomy_overview_vocabularies() theme functions in favour of table #type
#599770: Clean up the contact forms listing UI: Allow to set the default category and weights on the listing page
Comment | File | Size | Author |
---|---|---|---|
#25 | interdiff.txt | 517 bytes | andypost |
#25 | 1891690-voc-list-25.patch | 10.54 KB | andypost |
#23 | interdiff.txt | 679 bytes | andypost |
#23 | 1891690-voc-list-23.patch | 10.54 KB | andypost |
#16 | interdiff.txt | 1.43 KB | andypost |
Comments
Comment #1
larowlanAlso #1891746: Make vocabulary label in administrative listing link to its list of terms
Comment #2
andypostInitial patch, code mostly inherits #1855402: Add generic weighting (tabledrag) support for config entities (DraggableListController)
Let's see how much broken
Comment #3
andypostMerge patch with generic to test.
Weight does not saved when Save clicked but works for Contact categories list
Comment #4
andypostMissed a hook menu change
Comment #5
andypostAnd final patch
Comment #6
jthorson CreditAttribution: jthorson commentedDon't mind the failures on -2, -3, and -4 ... I'm just doing some pruning to shorten up the queue. If you did want independent results from the previous patches, feel free to re-test.
Comment #8
andypostPostponed for #1855402: Add generic weighting (tabledrag) support for config entities (DraggableListController)
Comment #9
andypostRelated issue #1938932: Remove taxonomy_overview_terms() and taxonomy_overview_vocabularies() theme functions in favour of table #type
Comment #9.0
andypostAdded related
Comment #10
andypostI think better to limit the scope of the patch and make clean-up and refactoring in #1855402: Add generic weighting (tabledrag) support for config entities (DraggableListController)
So introduced on top of
FormInterface
same as for #1872870: Implement a RoleListController and RoleFormControllerComment #11
andypostRe-roll after #1807042: Reorganizie entity storage/list/form/render controller annotation keys
Comment #12
andypostre-roll
Comment #13
twistor CreditAttribution: twistor commentedLooks good. One major problem though, this adds a new operation, "Disable" to the dropbutton.
Missing @file.
Comment #14
andypostnice catch!
Patch also converts this listing to controller that was introduced in #1983844: Add EntityListController and convert picture.module callbacks to routes/controllers to provide a use-case
Comment #15
tim.plunkettWhy are you changing this string in a conversion issue?
Comment #16
andypostSo back to original. I think "Save order" better describes that but let's leave it for #1855402: Add generic weighting (tabledrag) support for config entities (DraggableListController)
Comment #17
tim.plunkettThanks!
Comment #18
twistor CreditAttribution: twistor commentedThis still has the "Disable" link in the dropbutton.
Comment #19
tim.plunkett@twistor please open an issue to fix that generically, those should not be added unless the ConfigEntity defines a status entity_key.
Comment #20
tim.plunkettNevermind, I opened it.
#1994910: ConfigEntity listing should only show enable/disable if status is supported
Comment #21
alexpottThis looks unnecessary... and if it is... it certainly needs a comment. I've tested the code without this and it works as expected.
Comment #22
alexpottSo this adds the ability to drag the rows around to order the weight...
Comment #23
andypostComment added
Comment #24
jibranI think
,
shouldn't be here.Comment #25
andypostsure
Comment #26
amateescu CreditAttribution: amateescu commentedOn the contrary, it should. This is not JavaScript :) The correct patch is the one from #23.
Comment #27
andypost@amateescu no, all
entity_keys
in core have no last comma. seems it does not matter at all (bot will show)Comment #28
amateescu CreditAttribution: amateescu commentedOh, that was in the annotation? Sorry @jibran, my bad :/
Comment #30
andypost#25: 1891690-voc-list-25.patch queued for re-testing.
Comment #31
podarok#25 looks good for me
lets make it commited
Comment #32
alexpottCommitted 4370959 and pushed to 8.x. Thanks!
Comment #33.0
(not verified) CreditAttribution: commentedUpdated issue summary.