When an Ad is marked as Inactive, it is still included in the query to randomly select an ad for that region. So, for example, if you set the region to only display a single random ad, sometimes the inactive ad is selected, which then doesn't display. Basically, the field_ad_status field needs to be included in the original query. Patch forthcoming.

CommentFileSizeAuthor
#1 simpleads_inactive_ads-1889622-1.patch845 bytesmpotter

Comments

mpotter’s picture

mpotter commented
StatusFileSize
new simpleads_inactive_ads-1889622-1.patch845 bytes

Here is the patch on 1.8. Should work on dev also.

firfin’s picture

firfin commented
Status: Active » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Works great for me, thanks!

Matthew Kivett’s picture

Matthew Kivett commented

Duplicate of this issue is located here: http://drupal.org/node/1947654

This one was here first, but thought it might be good to point anyone interested towards the comments in the other one.

firfin’s picture

firfin commented

Marked #1947654: Inactive published ads problem as duplicate.

pmusaraj’s picture

pmusaraj commented

This patch worked for me as well. It seems to be something that would be a high priority to roll into next release.

dgtlmoon’s picture

dgtlmoon commented
Version: 7.x-1.8 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-1.x , does this also affect 7.x-2.x ?

pmusaraj’s picture

pmusaraj commented

I'm not sure, I was using 1.8. THanks for committing to dev!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

7.x-2.x is only released as a -dev, and I doubt too many people are using it on sites. You would probably know better than we would where the equivalent query is being done in your code, so you can check and see if 7x-2.x is affected as well? It's only a 3-lines-changed patch. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.