The button of Twitter to sign-in should be hidden when the maintenance mode is ON like Drupal for Facebook module does.

CommentFileSizeAuthor
#4 twitter-n1886540-4-6.x-5.x.patch2.22 KBdamienmckenna
#3 twitter-n1886540-3.patch2.25 KBdamienmckenna

Comments

rooby’s picture

rooby commented
Title: No button to sign-in on maintenance mode! » Sign-in button still appears when the site is in maintenance mode
Category: feature » bug
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Parent issue: » #2402311: Plan for Twitter v6.x-5.2 release
Related issues: +#2402307: Plan for Twitter v7.x-5.9 release, +#2402309: Plan for Twitter v7.x-6.0 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new twitter-n1886540-3.patch2.25 KB

This blocks logins by default, but it adds an option that would allow it, so that admins can still login.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.x-dev » 6.x-5.x-dev
StatusFileSize
new twitter-n1886540-4-6.x-5.x.patch2.22 KB

The last patch works for both 7.x-6.x and 7.x-5.x. This one is for 6.x-5.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed c72472c on 6.x-5.x 
    Issue #1886540 by DamienMcKenna: By default don't allow logins when the...

  • DamienMcKenna committed 92e2ea5 on 
    Issue #1886540 by DamienMcKenna: By default don't allow logins when the...

  • DamienMcKenna committed 71ffbc5 on 7.x-6.x 
    Issue #1886540 by DamienMcKenna: By default don't allow logins when the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.