Remove external JS and replace with FAPI #AJAX [#1886392]

Comment	File	Size	Author
#2	quiz_fapi_ajax.patch	48.47 KB	orbmantell
	fapi_ajax.patch	82.74 KB	orbmantell

Comment #1

sivaji_ganesh_jojodae commented 12 January 2013 at 14:31

Status:

Needs review

» Needs work

Your patch seems to remove the feature introduced in #1876104: Add option to mark a question as doubtful while answering. In brief it is doing something different from what has been mention in issue summary.

Log in or register to post comments

Comment #2

orbmantell commented 15 January 2013 at 21:44

Status:

Needs work

» Needs review

Status	File	Size
new	quiz_fapi_ajax.patch	48.47 KB

I just re-wrote and re-rolled the patch... it should no longer delete functionality.

Log in or register to post comments

Comment #3

orbmantell commented 18 January 2013 at 16:31

Status:

Needs review

» Closed (won't fix)

Is there anything I can do to help get this reviewed?

Log in or register to post comments

Comment #4

orbmantell commented 18 January 2013 at 16:31

Status:

Closed (won't fix)

» Needs review

Accidentally closed the wrong issue

Log in or register to post comments

Comment #5

Sherbet commented 20 January 2013 at 22:33

I will try this out and will let you know how it fares. Will this also fix the issues I experienced here http://drupal.org/node/1861046 ?

Log in or register to post comments

Comment #6

orbmantell commented 21 January 2013 at 17:51

This should fix any issues with the question admin page for a quiz.

I did simplify the form a bit (mainly the question search) because I was running into issues making all the old functionality work and I figured a simple working module is better than a fancy broken one. Once this is committed I can work on adding back in some of that functionality.