I have been working on a re-write of the question management tab for quizzes so it uses Drupal-native ajax in the form. I have created a patch of the changes and would like to submit it for review and committing if no bugs are found.

Files: 
CommentFileSizeAuthor
#2 quiz_fapi_ajax.patch48.47 KBorbmantell
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch quiz_fapi_ajax.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
fapi_ajax.patch82.74 KBorbmantell
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch fapi_ajax.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

sivaji@knackforge.com’s picture

Status:Needs review» Needs work

Your patch seems to remove the feature introduced in #1876104: Add option to mark a question as doubtful while answering. In brief it is doing something different from what has been mention in issue summary.

orbmantell’s picture

Status:Needs work» Needs review
StatusFileSize
new48.47 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch quiz_fapi_ajax.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

I just re-wrote and re-rolled the patch... it should no longer delete functionality.

orbmantell’s picture

Status:Needs review» Closed (won't fix)

Is there anything I can do to help get this reviewed?

orbmantell’s picture

Status:Closed (won't fix)» Needs review

Accidentally closed the wrong issue

Sherbet’s picture

I will try this out and will let you know how it fares. Will this also fix the issues I experienced here http://drupal.org/node/1861046 ?

orbmantell’s picture

This should fix any issues with the question admin page for a quiz.

I did simplify the form a bit (mainly the question search) because I was running into issues making all the old functionality work and I figured a simple working module is better than a fancy broken one. Once this is committed I can work on adding back in some of that functionality.

bpadaria’s picture

Issue summary:View changes

No questions are listed in "Manage Questions" tab.

djdevin’s picture

Status:Needs review» Closed (won't fix)

Fixed in 5.x.

falcon’s picture

Status:Closed (won't fix)» Needs review

The last submitted patch, fapi_ajax.patch, failed testing.

Status:Needs review» Needs work

The last submitted patch, 2: quiz_fapi_ajax.patch, failed testing.