Hey there,
I'm working on getting Subscriptions into a SOLR Facet today so I've created this Issue to post a patch should I get this to work.
Hey there,
I'm working on getting Subscriptions into a SOLR Facet today so I've created this Issue to post a patch should I get this to work.
Comments
Comment #1
yanniboi commentedComment #2
berdirHuh, that is interesting ;) I like it when standardizing on entities allows to do cool stuff like this.
However, I think that this should be using the normal info() hook, not alter, as we define new properties for our own entity type, not alter something. And the new way of doing this is the metadata controller, which we already define, so you should be able to just stuff this into SimplenewsSubscriberMetadataController.
Comment #3
yanniboi commentedYou have no idea how much easier 2.x-1.x makes our lives! Rules integration for VBO, SOLR facets. I have the day off today because you make it so easy :) (So what better way to spend a day off than to contribute to the community)
Comment #4
yanniboi commentedI've taken your advice and moved it to the Metadata Controller. Any other improvements just let me know.
Comment #5
berdirHm, not quite sure but I think we want to keep the callback in the .module. I don't think the .info.inc file is always loaded, probably just when this properties are rebuilt?
Comment #6
yanniboi commentedMakes sense!
Comment #8
berdir#6: simplenews-simplenews_subscriptions_in_solr-1886022-6.patch queued for re-testing.
Comment #9
berdirThanks, commited.