Segfault with large number of arguments in views_break_phrase() [#1884772]

The regular expressions in views_break_phrase() can cause a segmentation fault if there is a large number of arguments passed to the view due to the amount of recursion. This can be solved one of two ways:

Change pcre.backtrack_limit to a more reasonable value. The question here is: what is reasonable? Relying on the end-user to set this appropriately for their installation may be a bit much to ask considering the relative obscurity of this feature.
Refactor the regular expressions to avoid the amount of recursion causing the segmentation fault, namely the ([0-9]+[+ ])+ portion.

Comment	File	Size	Author
#1	views-arguments-regex-segfault-1884772-1.patch	774 bytes	BassistJimmyJam
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

BassistJimmyJam CreditAttribution: BassistJimmyJam commented 10 January 2013 at 01:59

Status:

Active

» Needs review

File	Size
views-arguments-regex-segfault-1884772-1.patch	774 bytes

Patch attached.

Comment #2

dawehner

German

CreditAttribution: dawehner commented 11 January 2013 at 07:13

How many arguments did you passed into the view to cause a seg.fault? Is this a number you can estimate?

In general there are multiple issues in both views and drupal issue queue to simplify the regular expression.

Comment #3

BassistJimmyJam CreditAttribution: BassistJimmyJam commented 11 January 2013 at 13:57

I had over 7000 arguments being passed to the view. I'm not sure what the minimum number of arguments would be that would cause this issue. I searched the views issue queue before posting but was unable to find any issues addressing these specific regular expressions.

Comment #4

dawehner

German

CreditAttribution: dawehner commented 12 January 2013 at 03:36

Yeah maybe not that easy to find, sorry: #1792836: Merge HandlerBase::breakPhrase() and HandlerBase::breakPhraseString() and clean up

Comment #5

dawehner

German

CreditAttribution: dawehner commented 14 January 2013 at 15:50

In general this sounds wrong: 7k arguments to a view, ... can you please have a look at the other issue whether that new regex makes it easier?

Comment #6

BarisW CreditAttribution: BarisW commented 22 January 2014 at 13:49

I was having a similar issue. On Drupal Commons, visiting the /activity page as a logged-in user, I was getting the segmentation fault as well. Described here: #2150673: Activity overview is broken for normal users

Comment #7

BarisW CreditAttribution: BarisW commented 10 December 2014 at 13:04

Issue summary:

View changes

Can this be committed?

Comment #8

clemens.tolboom

Dutch

Groningen, 🇳🇱/🇪🇺

CreditAttribution: clemens.tolboom commented 11 December 2014 at 13:15

Hmmm ... the Drupal 8 views fix in #1792836: Merge HandlerBase::breakPhrase() and HandlerBase::breakPhraseString() and clean up does not follow the patch from #1 regarding recursion depths.

- if (preg_match('/^([0-9]+[+ ])+[0-9]+$/', $str)) {
+ // Determine if the string has 'or' operators (plus signs) or 'and'
+ // operators (commas) and split the string accordingly.
+ if (preg_match('/^([\w0-9-_]+[+ ]+)+[\w0-9-_]+$/u', $str)) {

@BassistJimmyJam where did those 7K argument come from?

Side info : nice way to test @ http://www.phpliveregex.com/

Comment #9

BassistJimmyJam CreditAttribution: BassistJimmyJam commented 11 December 2014 at 15:43

It's been awhile since I ran into this, but I believe they came form a default argument plugin. Those arguments were also passed to the link for the attached CSV export.