Problem/Motivation

The default favicon in /misc/favicon.ico is 16x16 and looks awful on retina screens.

Proposed resolution

Replace misc/favicon.ico with a retina version. See https://github.com/audreyr/favicon-cheat-sheet for comprehensive information but in this case we are merely trying to fix the basic icon.

Remaining tasks

  • Create a 32x32 favicon.
  • Test on various devices.
  • Backport.

User interface changes

Non-pixelated favicons should appear on browser tabs.

Before:

After:

API changes

Any derived themes that may somehow depend on a 16x16 icon could have an issue.

Original report by @aendrew

CommentFileSizeAuthor
#21 1883058-21.patch6.63 KBcilefen
#5 after.png43.01 KBcilefen
#5 before.png33.81 KBcilefen
#4 1883058-4.patch6.65 KBcilefen
#1 drupal-replaced_favicon_with_retina_version-1883058-1.patch2.62 KBaendra

Comments

aendra’s picture

aendra commented
Status: Active » Needs review
StatusFileSize
new drupal-replaced_favicon_with_retina_version-1883058-1.patch2.62 KB

And a patch. File used is the one specified above (I.e., http://drupal.org/misc/favicon.ico).

aendra’s picture

aendra commented
Title: Default Drupal drop icon needs a Retina-quality version » Default Drupal "drop" favicon needs a Retina-quality version

Updating title for clarity.

aendra’s picture

aendra commented
Issue summary: View changes

Clarified "perfect".

aendra’s picture

aendra commented
Issue summary: View changes

Added article link.

cilefen’s picture

cilefen commented
Version: 7.18 » 8.x-dev
Component: other » Stark theme
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Novice

Updated the summary, tagged "novice", changed to 8.x and component "Stark theme".

cilefen’s picture

cilefen commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 1883058-4.patch6.65 KB
cilefen’s picture

cilefen commented
StatusFileSize
new before.png33.81 KB
new after.png43.01 KB

Before:

After:

cilefen’s picture

cilefen commented
Issue summary: View changes
davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented

I'm struggling to think why a theme would depend on the 16x16 file. Are there use cases anyone knows of? I believe it is documented that older browsers will size down the larger image.

cilefen’s picture

cilefen commented

The icon file in the patch contains 16x16 and 32x32.

cilefen’s picture

cilefen commented
Issue tags: +Needs manual testing
cilefen’s picture

cilefen commented
Issue summary: View changes
cilefen’s picture

cilefen commented
Issue tags: +Needs usability review
Bojhan’s picture

Bojhan commented
Issue tags: -Needs usability review

Sounds good.

sam152’s picture

sam152 commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing

Manually tested, looks great. Can't think of any reason this shouldn't be RTBC. Not sure anything would reasonably depend on the size of the icon.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Category: Feature request » Task
Status: Reviewed & tested by the community » Fixed

Nice!

Committed and pushed to 8.x. Thanks!

  • webchick committed 2ace268 on 8.0.x 
    Issue #1883058 by cilefen, aendrew: Added Default Drupal drop favicon...

Status: Fixed » Needs work

The last submitted patch, 4: 1883058-4.patch, failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Fixed

Silly testbot.

cilefen’s picture

cilefen commented
Issue tags: +Needs backport to D7

Can anyone think of a reason not to backport this?

markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 8.0.x-dev » 7.x-dev
Status: Fixed » Active
Issue tags: -Needs backport to D7

I do not see why not, go for it.

dcam’s picture

dcam commented
Status: Active » Patch (to be ported)

Setting the status so it will get noticed by patch-porters.

cilefen’s picture

cilefen commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1883058-21.patch6.63 KB

D7 patch.

jecunningham2281’s picture

jecunningham2281 commented
Status: Needs review » Reviewed & tested by the community

Tested in Drupal 7.34 Everything Looks good to me.

chuchunaku’s picture

chuchunaku commented

#SprintWeekend2015

mikemiles86’s picture

mikemiles86
he/him
commented
Issue tags: +SprintWeekend2015

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 21: 1883058-21.patch, failed testing.

Status: Needs work » Needs review

dcam queued 21: 1883058-21.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 21: 1883058-21.patch, failed testing.

Status: Needs work » Needs review

David_Rothstein queued 21: 1883058-21.patch for re-testing.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs review » Reviewed & tested by the community

Testbot fluke.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 21: 1883058-21.patch, failed testing.

Status: Needs work » Needs review

dcam queued 21: 1883058-21.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed 9164413 on 7.x 
    Issue #1883058 by cilefen, aendrew: Default Drupal "drop" favicon needs...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.