I guess the module lacks of a small verification that disallow to display the 'Sign in with Twitter' block and the 'user/' button when the module hasn't being configured (no API Key available), IMHO.

CommentFileSizeAuthor
#5 twitter-n1878660-5-7.x-6.x.patch1.67 KBdamienmckenna
#4 twitter-n1878660-4-7.x-5.x.patch1.67 KBdamienmckenna
#3 twitter-n1878660-3-6.x-5.x.patch1.8 KBdamienmckenna

Comments

tajinder.minhas’s picture

tajinder.minhas commented
Issue summary: View changes

Yes i agree but this is same functionality with other social media login modules, like gauth and fblogin i dont think this is a very big issue or we can show a help text besides the block and login button to configure API key

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2402311: Plan for Twitter v6.x-5.2 release
Related issues: +#2402307: Plan for Twitter v7.x-5.9 release, +#2402309: Plan for Twitter v7.x-6.0 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.2 » 6.x-5.x-dev
StatusFileSize
new twitter-n1878660-3-6.x-5.x.patch1.8 KB

For 6.x-5.x - don't change the login or registration forms if the API key and secret values haven't been configured.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 6.x-5.x-dev » 7.x-5.x-dev
Status: Active » Needs review
StatusFileSize
new twitter-n1878660-4-7.x-5.x.patch1.67 KB

For 7.x-5.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.x-dev » 7.x-6.x-dev
StatusFileSize
new twitter-n1878660-5-7.x-6.x.patch1.67 KB

For 7.x-6.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed dbc5e89 on 7.x-5.x 
    Issue #1878660 by DamienMcKenna: Don't show the login/registration form...

  • DamienMcKenna committed 2bccfeb on 
    Issue #1878660 by DamienMcKenna: Don't show the login/registration form...

  • DamienMcKenna committed 3ca3172 on 7.x-6.x 
    Issue #1878660 by DamienMcKenna: Don't show the login/registration form...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.