Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
AFAICT the function action_views_form_substitutions (in core/modules/action/action.views.inc) has no purpose since the action module is using the standard tableselect javascript - see core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.php. I think this code is left-overs from the VBO select all implementation in D7 that had custom JS and CSS code.
Comment | File | Size | Author |
---|---|---|---|
#2 | core-action-1877612.patch | 788 bytes | hansfn |
Comments
Comment #1
dawehnerWe need this to make the select all box working, so I don't see a reason to remove it.
Comment #2
hansfn CreditAttribution: hansfn commentedThx for the quick reply, dawehner, but I think you are wrong. The code was needed before the action module started to use the standard tableselect javascript. I have attached a trivial patch so you can verify for yourself that select all still works after removing this function.
To give your more detail: In D7 VBO, the label function of the class views_bulk_operations_handler_field_operations returned "<!--views-bulk-operations-select-all-->" (when applicable). The action module never does this, and hence the substitutions in action_views_form_substitutions has no effect.
Comment #5
naveenvalechaThis is no longer applicable AFAIT, Feel free to reopen