Introduced on commit in #1677054: Use file_entity_access() instead of media_access(), the access check for the media browser upload plugin uses the file_entity_access() API incorrectly.

I'm not sure exactly what the consequences are, but most likely it will result in the "create" permissions not being checked correctly.

CommentFileSizeAuthor
#1 media-browser-upload-1877214-1.patch489 bytesDavid_Rothstein

Comments

David_Rothstein’s picture

David_Rothstein commented
Status: Active » Needs review
StatusFileSize
new media-browser-upload-1877214-1.patch489 bytes

I guess it depends on if $account is actually passed in; in the case where it isn't, it's NULL anyway so this bug has no effect.

Easy to fix either way, though. The attached patch is untested but I'm pretty sure it should work.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

ugh, good catch!

ParisLiakos’s picture

ParisLiakos commented
Status: Reviewed & tested by the community » Fixed

thanks, commited

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

fix typo