Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Issue to track necessary changes once #1227706: Add a file entity access API goes in. Initial patch simply changes the upload plugin to use the new function.
Comment | File | Size | Author |
---|---|---|---|
#10 | media-file-access-1677054-10.patch | 2.99 KB | gooddesignusa |
#8 | media-file-access-1677054-08.patch | 2.95 KB | jhedstrom |
#5 | media-file-access-1677054-5.patch | 2.46 KB | Jackinloadup |
#2 | media-file-access-1677054-2.patch | 3.79 KB | Jackinloadup |
#1 | media-file-access-1677054-01.patch | 3.65 KB | jhedstrom |
Comments
Comment #1
jhedstromReplacing a few more instances of media_access with file_access.
Comment #2
Jackinloadup CreditAttribution: Jackinloadup commentedfixed some hook_menu arguments
Comment #3
jpstrikesback CreditAttribution: jpstrikesback commentedTested uploads, working great
Comment #4
gooddesignusa CreditAttribution: gooddesignusa commentedThis patch doesn't seem to apply to the latest dev of 2012-Aug-25.
If you use http://drupalcode.org/project/media.git/tree/1a0304dc62a468cf3fef7559cd6...
the patch applies cleanly.
Comment #5
Jackinloadup CreditAttribution: Jackinloadup commentedall the changes are due to #1293908: Respect file type restrictions in media browser library view getting in ^_^
attached is a here is a reroll
I changed all the places where we asked for 'edit' privileges to 'update'
Comment #6
Jackinloadup CreditAttribution: Jackinloadup commentedI'm going to mark this as postponed as we can't do reviews until #1227706: Add a file entity access API is in anyway.
Comment #7
gooddesignusa CreditAttribution: gooddesignusa commentedThanks for rerolled patch. It seems that upload tab for the media browser still wont show unless the user has the permission 'Administer files'. I verified I did apply the file_entity-file-access-1227706-71.patch from the other thread. I did notice there was a newer patch. I reversed the above patch and applied file_entity-file-access-1227706-78.patch. I also applied the patch from http://drupal.org/node/1422260#comment-6415726. Flushed cache and still no luck.
Comment #8
jhedstromPatch from #5 still had a lingering call to
media_access()
in MediaBrowserUpload.Comment #9
jpstrikesback CreditAttribution: jpstrikesback commentedLet's get #8 tested (changing status)
Comment #10
gooddesignusa CreditAttribution: gooddesignusa commentedfile_access needed to be updated to file_entity_access. The naming got changed a couple patches ago.
I did test it the latest patch http://drupal.org/node/1227706#comment-6627060 and it seems to be working.
I manually edited the patch and swapped out file_access, should still work fine. I've never manually edited a .patch file before.
Comment #11
ParisLiakos CreditAttribution: ParisLiakos commentedthanks all, commited with some changes
Comment #13
David_Rothstein CreditAttribution: David_Rothstein commentedThe changes on commit look like they introduced a bug; see #1877214: Media browser upload plugin permission check is incorrect.