Improve DX when writing style plugins by adding a renderRowGroup() function

This looks okay to me, but I'm not sure why it failed.

We should probably add a test plugin that uses this. Also, it should likely be protected. Otherwise, I think this is perfect.

Now that it's protected, its just an internal implementation detail. So no need for dedicated tests.

Hm. I don't think I'd ever intuit that a method called "renderSingle" had anything to do with groups or grouping without digging into the PHPDoc. Seems like "renderGroup" or "renderSingleGroup" woud be better?

Although, it's kinda weird we need this distinction. render() doesn't generally care whether it's rendering one of something or a nested several of something. You point it at a key and go.

Can more information be provided on why this is necessary?

Well, Views render() predates the Render API :(
The grouping bit is about this:

Internally, Views always calls render_grouping_sets(), but with only 1 set.

When overriding how a set renders, multiple or not, it will be really useful to have this method split out from the others.

Yeah, renderSingleGroup() might be a better method name.

"Renders a single group of a grouped view." => renderSingleGroup()

@webchick++ @xjm++

Yep, that definitely makes sense!

Random failure

Thanks, I think that'll be clearer to people.

Committed and pushed to 8.x. Thanks!

I thought this might need a change notice, and Tim agreed, so moving it to the Views queue.

@dawehner, I think we should put a snippet of an example D7 style plugin and then a D8 one using this method, so that people can see how much better it is in context.

Well, the D7 plugin would presumably have overridden and copied all of the equivalent of StylePluginBase::render_grouping_sets() just to add a little custom code to the group, right? I have painful memories of doing something along those lines in D6 days. So the "pre-change" version (not necessarily D7 I guess, just without the new method) could just have a clone of render_grouping_sets() with the additional parameter of your example inside?

Right, it doesn't actually need to do anything other than add your '#additional_parameter' => 'foo' I think.

I have updated http://drupal.org/node/1957350 and I also think we need \StylePluginBase::render_grouping_set as well to render single group.

    $theme_functions = views_theme_functions('views_view_grouping', $this->view, $this->view->display_handler->display);
    foreach ($sets as $set) {
      $row = reset($set['rows']);
      // Render as a grouping set.
      if (is_array($row) && isset($row['group'])) {
        $output[] = array(
          //what if I don't want to use theme_views_view_grouping. Something like this :link          
          '#theme' => $theme_functions, 
          '#view' => $this->view,
          '#grouping' => $this->options['grouping'][$level],
          '#grouping_level' => $level,
          '#rows' => $set['rows'],
          '#title' => $set['group'],
        );
      }

:link => http://drupalcode.org/sandbox/jibran/1867222.git/blob/refs/heads/7.x-1.x...

Just talked to @dawehner on IRC we can add above function to views in D7 I will post the patch soon.

follow up #1961702: Rename renderSingleGroup to renderRowGroup

That looks good! Now on to the backport.

D7 patch.

Title was driving me crazy. :)

And let's respect the followup change too.

Created #1963420: Improve DX when writing style plugins by adding a groupingTheme variable for #34

The 6 year old patch in #37 to views_plugin_style.inc does not apply to the latest views 7.x-3.x-dev and if still applicable needs to be rerolled.

Checking patch plugins/views_plugin_style.inc...
error: while searching for:
  }

  /**
   * Render the display in this style.
   */
  function render() {

error: patch failed: plugins/views_plugin_style.inc:309
error: plugins/views_plugin_style.inc: patch does not apply

Patch rerolled.