When viewing a queue, if the user does not have access to view the node, the title column of the queue table is empty. After looking at the code, it's supposed to say something like "Restricted node, NID:". That doesn't show because #value is being used where #markup should be used. This was most-likely overlooked during a port from D6.

Patch coming..

CommentFileSizeAuthor
#1 nodequeue-missing_node_empty_text-1873570-1.patch972 bytesmstef
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mstef’s picture

mstef CreditAttribution: mstef commented
Status: Active » Needs review
FileSize
nodequeue-missing_node_empty_text-1873570-1.patch972 bytes

Patch

othermachines’s picture

othermachines CreditAttribution: othermachines commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Amazingly enough (given its age), this patch is good.

I came upon this issue over here: Issue #2318535: Node titles not displayed in subqueue admin when access denied by domain_access module.

I agree that this is cruft from D6 and a dead simple fix left sitting for 2 years. Marking RTBC.

Edit: Updated title of referenced issue.

othermachines’s picture

othermachines CreditAttribution: othermachines commented
Priority: Normal » Major

Marking as major since it makes the subqueue admin virtually unusable under certain circumstances (in the case of the Smartqueue Domain module, when the subqueue contains nodes that belong to a domain other than the active domain).

  • fizk committed 4d46c2b on 7.x-2.x authored by mstef 
    Issue #1873570 by mstef: Non-visible nodes show no title on the admin...
fizk’s picture

fizk CreditAttribution: fizk commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.