Apparently our test coverage doesn't extend to node revision links, they were broken and then fixed again in #2322949: Implement generic entity link view field handlers.

Files: 
CommentFileSizeAuthor
#100 interdiff-1863898-100.txt10.74 KBlokapujya
#99 interdiff-1863898-76-96.txt24.85 KBlokapujya
#96 views_revision_link-1863898-96.patch10.38 KBjeqq
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 109,096 pass(es). View
#94 views_revision_link-1863898-94.patch10.38 KBjeqq
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 98,642 pass(es). View
#87 views_revision_link-1863898-87.patch10.35 KBjeqq
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 98,500 pass(es). View
#79 1863898-79.patch21.92 KBlokapujya
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] Unable to apply patch 1863898-79_0.patch. Unable to apply patch. See the log in the details link for more information. View
#79 interdiff-1863898-72-76.txt1.45 KBlokapujya
#76 1863898-76-test-only.patch10.46 KBlokapujya
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 88,575 pass(es), 7 fail(s), and 0 exception(s). View
#74 1863898-74-test-only.patch0 byteslokapujya
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 88,508 pass(es). View
#72 1863898-72.patch22.12 KBlokapujya
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 88,010 pass(es). View
#72 1863898-72-test-only.patch10.66 KBlokapujya
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 88,025 pass(es). View
#69 interdiff-1863898-68.txt7.66 KBlokapujya
#69 1863898-68.patch22.12 KBlokapujya
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 1863898-68.patch. Unable to apply patch. See the log in the details link for more information. View
#67 views_revision_link-1863898-67.patch21.79 KBpcambra
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,763 pass(es), 69 fail(s), and 0 exception(s). View
#67 interdiff.txt4.35 KBpcambra
#63 views_revision_link-1863898-63.patch21.3 KBcriscom
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 78,862 pass(es). View
#61 1863898-61.patch21.3 KBlokapujya
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 78,801 pass(es). View
#56 1863898-56.patch21.2 KBlokapujya
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 1863898-56.patch. Unable to apply patch. See the log in the details link for more information. View
#56 interdiff.txt5.96 KBlokapujya

Comments

dawehner’s picture

FileSize
10.85 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1863898-1.patch. Unable to apply patch. See the log in the details link for more information. View

/me sighs

Not sure whether you (other person) will find this code helpful, but maybe you do so here is it.

tim.plunkett’s picture

Status:Active» Needs review
FileSize
10.9 KB
FAILED: [[SimpleTest]]: [MySQL] 50,100 pass(es), 7 fail(s), and 1 exception(s). View

Rerolled.

Status:Needs review» Needs work

The last submitted patch, vdc-1863898-2.patch, failed testing.

dawehner’s picture

Assigned:Unassigned» dawehner

Working on that ... what a pain.

dawehner’s picture

FileSize
11.88 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1863898.patch. Unable to apply patch. See the log in the details link for more information. View

This is really just temporary code-tracking.

jibran’s picture

Status:Needs work» Needs review
FileSize
808 bytes
11.67 KB
FAILED: [[SimpleTest]]: [MySQL] 56,093 pass(es), 1 fail(s), and 0 exception(s). View

Re-roll. Interdiff is for minor change in core.

Status:Needs review» Needs work

The last submitted patch, 1863898-6.patch, failed testing.

jibran’s picture

Status:Needs work» Needs review
FileSize
9.29 KB
16.57 KB
FAILED: [[SimpleTest]]: [MySQL] 57,571 pass(es), 8 fail(s), and 0 exception(s). View

Updated the old view and minor nip tuck.

Status:Needs review» Needs work

The last submitted patch, 1863898-8.patch, failed testing.

jibran’s picture

Status:Needs work» Needs review
FileSize
2 KB
16.6 KB
FAILED: [[SimpleTest]]: [MySQL] 56,368 pass(es), 8 fail(s), and 0 exception(s). View

This will fix the test.

jibran’s picture

FileSize
2 KB

This will fix the test.

Status:Needs review» Needs work
Issue tags:-Needs tests, -VDC

The last submitted patch, 1863898-10.patch, failed testing.

dawehner’s picture

Status:Needs work» Needs review

#10: 1863898-10.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Needs tests, +VDC

The last submitted patch, 1863898-10.patch, failed testing.

jibran’s picture

Well according to verbose messages the test is correct. I have the same 8 fails locally.

pcambra’s picture

Status:Needs work» Needs review
FileSize
16.44 KB
PASSED: [[SimpleTest]]: [MySQL] 56,728 pass(es). View

Here's a re-roll of #10

I've fixed some minor things, like invoking camel cased views methods and fixing the "revisions" link as it should be in plural form, also the test view was disabled so no way to test the path.

Also removed testing the view link as the view op is always available (no particular permission for that).

jibran’s picture

Issue tags:-Needs tests
FileSize
3.98 KB
17.9 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View

Here is the reroll and some minor fixes.

jibran’s picture

FileSize
704 bytes
17.84 KB
FAILED: [[SimpleTest]]: [MySQL] 58,525 pass(es), 5 fail(s), and 49 exception(s). View

:/

Status:Needs review» Needs work

The last submitted patch, drupal8.node-module.1863898-18.patch, failed testing.

damiankloip’s picture

Status:Needs work» Needs review
FileSize
6.85 KB
18.01 KB
PASSED: [[SimpleTest]]: [MySQL] 58,120 pass(es). View

Here are a couple more fixes. This should also fix the RevisionLinkTest test too.

dawehner’s picture

  1. +++ b/core/modules/node/lib/Drupal/node/Plugin/views/field/RevisionLink.php
    @@ -21,29 +21,48 @@
    +  public $countRevisions;
    

    No need for a public property.

  2. +++ b/core/modules/node/lib/Drupal/node/Plugin/views/field/RevisionLink.php
    @@ -21,29 +21,48 @@
    +  function preRender(&$values) {
    

    There should be a visibility.

  3. +++ b/core/modules/node/lib/Drupal/node/Plugin/views/field/RevisionLink.php
    @@ -21,29 +21,48 @@
    +      $this->countRevisions = db_query("SELECT nid, COUNT(vid) as count FROM {node_field_revision} WHERE nid IN (:nids) GROUP BY nid", array(':nids' => array_unique($nids)))->fetchAllKeyed();
    

    Let's use an injected database connection.

  4. +++ b/core/modules/node/lib/Drupal/node/Plugin/views/field/RevisionLinkDelete.php
    @@ -20,18 +20,19 @@
    +    if (!($access = (user_access("delete $type revisions") || user_access('delete all revisions') || user_access('administer nodes')) && node_access('delete', $revision_node))) {
    
    +++ b/core/modules/node/lib/Drupal/node/Plugin/views/field/RevisionLinkRevert.php
    @@ -20,18 +20,19 @@
    +    if (!($access = (user_access("revert $type revisions") || user_access('revert all revisions') || user_access('administer nodes')) && node_access('update', $node))) {
    

    We can also replace user_access with \Drupal::currentUser()->hasPermission

jibran’s picture

Assigned:dawehner» jibran
Status:Needs review» Needs work

working on it.

jibran’s picture

Assigned:jibran» Unassigned
Status:Needs work» Needs review
FileSize
7.52 KB
20.9 KB
FAILED: [[SimpleTest]]: [MySQL] 58,014 pass(es), 24 fail(s), and 15 exception(s). View

Fixed #21 and some clean up.

Status:Needs review» Needs work

The last submitted patch, drupal8.node-module.1863898-23.patch, failed testing.

jibran’s picture

Status:Needs work» Needs review
FileSize
2.65 KB
20.89 KB
PASSED: [[SimpleTest]]: [MySQL] 58,436 pass(es). View

Fixed tests and typo :S

dawehner’s picture

  1. +++ b/core/modules/node/lib/Drupal/node/Plugin/views/field/Link.php
    @@ -55,11 +56,21 @@ public function render(ResultRow $values) {
       protected function renderLink($node, ResultRow $values) {
    

    Can we also typehint on the actual code?

  2. +++ b/core/modules/node/lib/Drupal/node/Tests/Views/RevisionLinkTest.php
    @@ -0,0 +1,106 @@
    +    $this->assertNoLinkByHref($uri['path'] . '/revisions/' . $this->revisions[0]->vid->value . '/delete');
    +    $this->assertNoLinkByHref($uri['path'] . '/revision/' . $this->revisions[0]->vid->value . '/revert');
    ...
    +    $this->assertLinkByHref($uri['path'] . '/revisions/' . $this->revisions[1]->vid->value . '/view');
    +    $this->assertLinkByHref($uri['path'] . '/revisions/' . $this->revisions[1]->vid->value . '/delete');
    +    $this->assertLinkByHref($uri['path'] . '/revisions/' . $this->revisions[1]->vid->value . '/revert');
    ...
    +    $this->assertNoLinkByHref($uri['path'] . '/revisions/' . $this->revisions[2]->vid->value . '/delete');
    +    $this->assertNoLinkByHref($uri['path'] . '/revisions/' . $this->revisions[2]->vid->value . '/revert');
    ...
    +          $this->assertLinkByHref($uri['path'] . '/revisions/' . $this->revisions[1]->vid->value . '/' . $operation);
    ...
    +          $this->assertNoLinkByHref($uri['path'] . '/revisions/' . $this->revisions[1]->vid->value . '/' . $operation);
    

    Can't we just use getRevisionId() ?

jibran’s picture

FileSize
4.03 KB
21.28 KB
FAILED: [[SimpleTest]]: [MySQL] 58,688 pass(es), 296 fail(s), and 962 exception(s). View

Fixed #27.

damiankloip’s picture

+++ b/core/modules/node/lib/Drupal/node/Plugin/views/field/Link.php
@@ -43,6 +44,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+    $this->ensureMyTable();

Do we really need to add this call here? We probably don't really even need the query method? or empty query method?

Otherwise, this is looking pretty good.

Status:Needs review» Needs work

The last submitted patch, drupal8.node-module.1863898-27.patch, failed testing.

jibran’s picture

Status:Needs work» Needs review
FileSize
1.07 KB
21.3 KB
FAILED: [[SimpleTest]]: [MySQL] 57,944 pass(es), 140 fail(s), and 82 exception(s). View

I have removed query method. And reverting the typehinit of renderLink to match the parent definition.

Status:Needs review» Needs work

The last submitted patch, drupal8.node-module.1863898-30.patch, failed testing.

jibran’s picture

Status:Needs work» Needs review
FileSize
631 bytes
21.18 KB
FAILED: [[SimpleTest]]: [MySQL] 58,149 pass(es), 6 fail(s), and 84 exception(s). View

or empty query method?

Let's try that.

Status:Needs review» Needs work

The last submitted patch, drupal8.node-module.1863898-32.patch, failed testing.

damiankloip’s picture

I vote just reverting the changes to the query method and leaving it how it was. I think that will work for us?

jibran’s picture

Status:Needs work» Needs review
FileSize
514 bytes
21.21 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal8.node-module.1863898-35.patch. Unable to apply patch. See the log in the details link for more information. View

Reverted.

jibran’s picture

It is a quite day for VDC team anyone want to RTBC.

jibran’s picture

FileSize
507 bytes
21.01 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch drupal8.node-module.1863898-37.patch. Unable to apply patch. See the log in the details link for more information. View

Reverted all the changes of query method.

Status:Needs review» Needs work

The last submitted patch, drupal8.node-module.1863898-37.patch, failed testing.

damiankloip’s picture

Sorry, let's go with the patch in #35! I guess we do need to ensure the table..

damiankloip’s picture

Status:Needs work» Reviewed & tested by the community

rtbc for #35.

catch’s picture

Status:Reviewed & tested by the community» Needs review
+++ b/core/modules/node/lib/Drupal/node/Plugin/views/field/RevisionLinkRevert.php
@@ -20,18 +20,19 @@
+    if (!($access = ($this->currentUser->hasPermission("revert $type revisions") || $this->currentUser->hasPermission('revert all revisions') || $this->currentUser->hasPermission('administer nodes')) && node_access('update', $node))) {

Why's the access check being taken out of access() and put into the rendering?

damiankloip’s picture

Because access() is only called when handlers are initialised. If it failed here the handler would be removed from the view altogether. This needs to use the current node to determine the access, as well as user permissions.

catch’s picture

Won't preRender() run before renderLink() though? If so we're counting all the revisions for all the nodes when generating the delete/revert links, even if the user never has a chance of seeing them.

Also it might be too early here, but I can't see the access check being added back for the view link?

-  public function access() {
-    return user_access('view revisions') || user_access('administer nodes');
+  /**

+  /**
+   * {@inheritdoc}
+   */
   protected function renderLink($data, ResultRow $values) {
-    list($node, $vid) = $this->get_revision_entity($values, 'view');
-    if (!isset($vid)) {
-      return;
-    }
+    list($node, , $vid) = $this->getRevisionEntity($values, 'view');
 
     // Current revision uses the node view path.
-    $path = 'node/' . $node->nid;
-    if (!$node->isDefaultRevision()) {
+    $uri = $node->uri();
+    $path = $uri['path'];
+    if ($this->countRevisions[$node->id()] > 1 && $node->getRevisionId() != $vid) {
       $path .= "/revisions/$vid/view";
     }
damiankloip’s picture

I spoke to catch about this, we need to add back access. We have two levels here, whether we can view the node or not and whether we have a revision to access etc.. We need to check user_access still, as probably node_access() to determine if we even show a view link. So I think the current logic to revision linking is ok, we just need to add back the access stuff in some form. However, probably not in the access() method like before?

jibran’s picture

Status:Needs review» Needs work

The last submitted patch, 35: drupal8.node-module.1863898-35.patch, failed testing.

xjm’s picture

Component:node.module» node system
Issue summary:View changes

(Merging "node system" and "node.module" components for 8.x; disregard.)

xjm’s picture

Priority:Normal» Major
Issue tags:+beta target

This seems like a major regression to me, and it's also blocking views conversions.

kim.pepper’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 37: drupal8.node-module.1863898-37.patch, failed testing.

kim.pepper’s picture

Issue tags:+Needs reroll
lokapujya’s picture

Status:Needs work» Needs review
Issue tags:-Needs reroll
FileSize
21.12 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Invalid PHP syntax in core/modules/node/src/Plugin/views/field/RevisionLink.php. View

Re-roll. I ran out of time to figure out what to do about access(). Had to change node_access to node.access(). But, I think tests are going to fail there.

Status:Needs review» Needs work

The last submitted patch, 52: 1863898-52.patch, failed testing.

lokapujya’s picture

Status:Needs work» Needs review
FileSize
21.24 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 71,565 pass(es), 8 fail(s), and 0 exception(s). View

Fixed a double use statement.

Status:Needs review» Needs work

The last submitted patch, 54: 1863898-54.patch, failed testing.

lokapujya’s picture

Status:Needs work» Needs review
FileSize
5.96 KB
21.2 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 1863898-56.patch. Unable to apply patch. See the log in the details link for more information. View

Get the re-roll up to date with Core changes.

Jalandhar’s picture

Status:Needs review» Needs work
Issue tags:+Needs reroll

Patch needs reroll.

mgifford’s picture

Status:Needs work» Needs review

mgifford queued 56: 1863898-56.patch for re-testing.

Status:Needs review» Needs work

The last submitted patch, 56: 1863898-56.patch, failed testing.

lokapujya’s picture

Status:Needs work» Needs review
Issue tags:-Needs reroll
FileSize
21.3 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 78,801 pass(es). View

Rerolled.

criscom’s picture

Issue tags:+Amsterdam2014

Testing

criscom’s picture

FileSize
21.3 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 78,862 pass(es). View

Rerolled and patched successfully with no conflicts/errors.

jhedstrom’s picture

From #52

I ran out of time to figure out what to do about access().

Has the link access issue been resolved in the subsequent rerolls (it's hard to tell without interdiffs)? That comment is the only mention of catch's concern from #43.

lokapujya’s picture

access() is only called on handler initialization, so the access check was moved to renderLink(). My understanding is that we need a better place for the access check, so that preRender doesn't get called?

lokapujya’s picture

There must be similar access checks somewhere that give a clue how this should be done.

pcambra’s picture

Issue tags:-Amsterdam2014+Needs issue summary update
FileSize
4.35 KB
21.79 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,763 pass(es), 69 fail(s), and 0 exception(s). View

Just making a couple of nitpick changes to get the ball rolling on this.

Regarding the access discussion, last comment from @damiankloip is #1863898-44: Add test coverage for Views revision link handlers which suggests that we need to get the access check back, it appears that there are two kind of checks here:

  1. Generic user permissions, i.e. $this->currentUser->hasPermission('delete all revisions')
  2. Specific check for the user in the context, i.e. $revision_node->access('delete')

Could we add 1) back to access() method and keep 2) in the renderLink() method?
I understand this is an issue just for the Revert and Delete revision links.

Status:Needs review» Needs work

The last submitted patch, 67: views_revision_link-1863898-67.patch, failed testing.

lokapujya’s picture

Status:Needs work» Needs review
FileSize
22.12 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 1863898-68.patch. Unable to apply patch. See the log in the details link for more information. View
7.66 KB

I need to re-review this myself to make sure it's still relevant, but here is a re-roll.

mgifford queued 69: 1863898-68.patch for re-testing.

Status:Needs review» Needs work

The last submitted patch, 69: 1863898-68.patch, failed testing.

lokapujya’s picture

Status:Needs work» Needs review
FileSize
10.66 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 88,025 pass(es). View
22.12 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 88,010 pass(es). View

Still haven't look at the relevancy, but here is a start: Let's see the test only patch.

jhedstrom’s picture

Status:Needs review» Needs work

Hmm...the test only patch is passing, so it either isn't testing this issue, or this issue has been fixed elsewhere.

lokapujya’s picture

Issue summary:View changes
Status:Needs work» Needs review
FileSize
0 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 88,508 pass(es). View

The test wasn't running. I moved them to the right place, but the test don't seem to work either.

jhedstrom’s picture

Status:Needs review» Needs work

Patch above is empty.

lokapujya’s picture

Status:Needs work» Needs review
FileSize
10.46 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 88,575 pass(es), 7 fail(s), and 0 exception(s). View

Oh yeah, these are new files so git diff didn't pick them up.

Status:Needs review» Needs work

The last submitted patch, 76: 1863898-76-test-only.patch, failed testing.

jhedstrom’s picture

Nice. Can you upload the combined patch now that the test is being run?

lokapujya’s picture

Status:Needs work» Needs review
FileSize
1.45 KB
21.92 KB
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] Unable to apply patch 1863898-79_0.patch. Unable to apply patch. See the log in the details link for more information. View

Included interdiff to show what was changed in the view. Keep in mind that the test is failing (but not necessarily failing for the reasons that it should.) So, I still haven't tried to verify that the bug is still relevant. For example, the first fail is "Link containing href node/1 found." But, I think that we are expecting that part should work (even without the fix from this patch.)

Status:Needs review» Needs work

The last submitted patch, 79: 1863898-79.patch, failed testing.

jeqq’s picture

Issue summary:View changes

Status:Needs work» Needs review

jeqq queued 79: 1863898-79.patch for re-testing.

Status:Needs review» Needs work

The last submitted patch, 79: 1863898-79.patch, failed testing.

lokapujya’s picture

Issue tags:+Needs reroll

First, Needs a reroll.
Then, Needs someone to look at the newly added test. Verify that the test is actually testing the bug properly.

neetu morwani’s picture

Assigned:Unassigned» neetu morwani
neetu morwani’s picture

Assigned:neetu morwani» Unassigned
jeqq’s picture

Issue tags:-Needs reroll
FileSize
10.35 KB
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 98,500 pass(es). View

I think the the problem has been fixed in #2322949: Implement generic entity link view field handlers.

I've rerolled the patch, the test demonstrates that the links are displayed correctly.

jeqq’s picture

Status:Needs work» Needs review
lokapujya’s picture

Which patch was rerolled? Also, was this just a reroll or does it also have additional changes?

jeqq’s picture

The patch #87 contains only the test from #79. Other changes from #79 I think aren't relevant anymore.

lokapujya’s picture

It's just that 4 months ago the test was failing, and now it's passing. For completeness, it would be nice to know what changed.

lokapujya’s picture

@jeqq Basically, this needs an interdiff so that it the changes can be reviewed. It looks like 87 was more than a re-roll.

https://www.drupal.org/documentation/git/interdiff

lokapujya’s picture

Status:Needs review» Needs work
+++ b/core/modules/node/src/Tests/Views/RevisionLinkTest.php
@@ -0,0 +1,96 @@
+  public $revisions = array();

I think this is now unused and can be deleted. Other than that, it looks like we should commit this test.

jeqq’s picture

Status:Needs work» Needs review
FileSize
10.38 KB
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 98,642 pass(es). View

Thanks @lokapujya. I've removed the unused field. Unfortunately, for some reason I can't create an interdiff.

andrei@Andrei-NB:/var/www/drupal8dev$ interdiff views_revision_link-1863898-87.patch views_revision_link-1863898-94.patch > interdiff-87-94.txtThe next patch would create the file /tmp/interdiff-1.wZWeGm,
which already exists!  Assume -R? [n] 
Apply anyway? [n] 
interdiff: Error applying patch1 to reconstructed file
andrei@Andrei-NB:/var/www/drupal8dev$
lokapujya’s picture

Status:Needs review» Needs work

It would probably be easier to create 2 branches. First with the old patch, Second with the new patch. Then just diff the 2 branches.

+++ b/core/modules/node/src/Tests/Views/RevisionLinkTest.php

@@ -0,0 +1,101 @@
+  }
+  ¶

Some whitespace snuck in there.

jeqq’s picture

Status:Needs work» Needs review
FileSize
10.38 KB
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 109,096 pass(es). View

Removed the whitespace.

jeqq’s picture

lokapujya’s picture

FileSize
24.85 KB

Interdiff for reviewing. Oops I can see this is wrong by the filesize. Will try again later.

lokapujya’s picture

FileSize
10.74 KB

Had to adjust the diff between 76 and 96 to only include the test. Also, it seems the directory name of the test changed; In order to see what actually changed in the file, in the older branch, I first moved the the file from the old directory to the new one.

lokapujya’s picture

@jeqq: Can you verify that the interdiff is right?

jeqq’s picture

@lokapujya: The interdiff is right, thanks.

lokapujya’s picture

Status:Needs review» Reviewed & tested by the community

Now we can add this new test coverage.

alexpott’s picture

Category:Bug report» Task
Priority:Major» Normal
Status:Reviewed & tested by the community» Needs work
Issue tags:-beta target

Still needs an issue summary update... and a title update.

lokapujya’s picture

Title:Views revision link handlers are broken» Add test coverage for Views revision link handlers
Issue summary:View changes
Status:Needs work» Needs review
lokapujya’s picture

lokapujya’s picture

Issue summary:View changes
no_angel’s picture

Assigned:Unassigned» no_angel
lokapujya’s picture

Assigned:no_angel» Unassigned

no_angel, are you still reviewing this?

Version:8.0.x-dev» 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.