I'm not sure that this makes as much sense for a ConfigEntity, but we'll see how it pans out.

Mostly this stems from not knowing when to use execute()/executeDisplay/preview().

It only handles page displays right now, I'll expand it to blocks and ajax later.

CommentFileSizeAuthor
#16 vdc-1857422-16.patch32.91 KBbillywardrop
#1 vdc-1857422-1.patch5.04 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue tags: +VDC
FileSize
vdc-1857422-1.patch5.04 KB

Patch attached.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Postponed

Postponing on #1811828: Use #attached to find the css/js of a view and #1849356: Add a HTTP response code area handler
We want the render improvements from the first, and we have to support the usecase of the second.

Jelle_S’s picture

Jelle_S
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: Jelle_S commented

Small remark on current patch.

In the docblock of views_page():

+++ b/core/modules/views/views.moduleundefined
@@ -545,27 +552,22 @@ function views_arg_load($value, $name, $display_id, $index) {
+ * @param \Drupal\views\Plugin\Core\Entity\View $name

$name => $view

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

Yeah that whole change to the function signature should be reverted anyway. Did some testing and it was not a smart idea :)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Postponed » Closed (won't fix)

This doesn't a actually make any sense.

benjy’s picture

benjy CreditAttribution: benjy commented
Component: taxonomy.module » views.module
Category: Task » Feature request
Issue summary: View changes
Status: Closed (won't fix) » Active

This would be a nice feature basically a view could be rendered when you have an entity reference to a view.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Title: Add a render controller for Views » Add a ViewBuilder for Views
Assigned: tim.plunkett » Unassigned

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Version: 8.1.x-dev » 8.3.x-dev
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue tags: +Needs reroll
Manuel Garcia’s picture

Manuel Garcia CreditAttribution: Manuel Garcia at Appnovation commented
Status: Active » Needs work
danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
CreditAttribution: danylevskyi as a volunteer commented

We are on DrupalCon Dublin and we are going to fix this issue.

danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
CreditAttribution: danylevskyi as a volunteer commented
Issue tags: +Dublin2016
billywardrop’s picture

billywardrop CreditAttribution: billywardrop as a volunteer commented

I am working on this at DrupalCon Dublin

billywardrop’s picture

billywardrop CreditAttribution: billywardrop as a volunteer commented
FileSize
vdc-1857422-16.patch32.91 KB

Patch attached

billywardrop’s picture

billywardrop CreditAttribution: billywardrop as a volunteer commented

The patch is wrong, I'm working on a new patch

billywardrop’s picture

billywardrop CreditAttribution: billywardrop as a volunteer commented

I have checked the patch and the code is to old for the latest version of Drupal 8. The file structure no longer exists for this file:

"core/modules/views/lib/Drupal/views/Plugin/Core/Entity/View.php"

This patch needs a rework.

billywardrop’s picture

billywardrop CreditAttribution: billywardrop as a volunteer commented
Issue tags: -Needs reroll +Needs work

Removed Reroll and set this issue to Needs work

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

A view is always displayed with a specific display and possibly arguments. A view builder has no mechanism for passing this along. I think this should be won't fixed, the closest that core could offer would be a special field formatter that allows to select a display and maybe arguments, token based. but maybe that configuration should actually be a on the field, so it needs its own field type.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.