Needs review
Project:
Date
Version:
7.x-2.x-dev
Component:
Date Repeat API
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Dec 2012 at 08:15 UTC
Updated:
9 Nov 2018 at 11:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Exploratus commentedMe too!
Comment #2
Exploratus commentedCould it be a language issue?
Comment #3
phl3tch commentedThis appears to just be a simple case of the function at fault not checking whether $field['settings']['repeat'] actually exists. I've attached a patch which should probably be rolled into the next release, but in practice this error shouldn't cause any problems.
Comment #4
phl3tch commentedOops. Left a paren out of that last patch.
Comment #5
phl3tch commentedOh Lord, this is not my day.
One more correction. Honestly, this one works properly.
Comment #6
Exploratus commentedThanks, tested it and the error didnt come up when I uninstalled and reinstalled. Also, my date field kept dissapearing when I turned on the date repeat field module, and now it's not.
Comment #7
phl3tch commentedComment #9
phl3tch commentedSo I ran tests and found that this failure occurs regardless of whether patch #5 is installed or not. Anyone know what to do in that event?
Comment #10
h3rj4n commentedI also want to know that answer, also got a patch that works fine (#1866684: Value not inherited from parent element) but the test failes on some bug that was already there?
Comment #11
phl3tch commentedRetesting
Comment #12
redndahead commentedI think just having a !empty should take care of it.
Comment #14
WebSinPat commentedi get the same error upon enabling date repeat. I'm using 7.x.2.6, within drupal commons 7.x.3.2
I would apply a patch, once a solid one is submitted?
thanks.
Comment #15
jenifertucker commentedDitto.
Also getting the same message in Drupal 7.22 core and Date Repeat API 7.x-2.6 and Date Repeat Field 7.x-2.6.
Yet to see if it breaks anything (setting up multilanguage site).
Comment #16
redndahead commented#12: 1856305-d7-1.patch queued for re-testing.
Comment #18
mgiffordThe patch is pretty trivial. No idea why it is failing, but I can verify that it's still a problem.
Comment #19
TWD commentedUndefined index: repeat in date_repeat_field_bundles() (line 165 of /home1/MYSITE/public_html/sites/all/modules/date/date_repeat_field/date_repeat_field.module)
Subscribing.
Comment #20
jacobson commentedPlease note that "subscribing" to Issues is no longer good practice. You will see a Follow button at the top of every issue (if you are logged into d.o). Use the Follow button to subscribe.
Comment #21
jacobson commentedFix erroneous change of Issue title
Comment #22
kingfisher64 commentedThis is still an issue with the very latest dev of date version 7.x-2.x-dev 2013-Nov-29.
Any suggestions?
Comment #23
cmwelding commentedI am getting same error message:
Notice: Undefined index: repeat in date_repeat_field_bundles() (line 165 of /home/mysite/public_html/sites/all/modules/date/date_repeat_field/date_repeat_field.module).
I am using Date iCal for calendar feed and repeating dates only show up on the first day. Don't know if this problem is due to this error.
Comment #24
marcissimus commentedMy suggestion would be
Comment #25
maen commentedSaw this thread with a half bottle of wine in my head (no beer although I'm German), I solved this like this (too lazy to make a diff):
Comment #26
7thkey commentedMaen solution works, i did the diff patch over the dev version.
Changing the topic to development version.
Comment #27
7thkey commentedComment #28
joelstein commentedHere's a patch which fixes the same notice in a couple other places.
Comment #29
steinmb commentedEnv: drupal 7.x-dev PHP 7.2.11
Retested #28 and it is OK, but not really sure that we still need the empty checks outside
date_repeat_field_bundles()at least I was unable to provoke them on the latest date. Perhaps they have been addressed in other issues? I suggest we only address this one.date_repeat_field_bundles()is called from date_repeat_field_menu() (hook_menu) on installation and other operations so we have to check it.Roll a one liner. It also contain a micro optimization. Swapped the order so first always check a single value.