The field for Timeline JS media is just a plain URL. As it's currently implemented, only the image module is supported, which is extremely limiting given that one of the features is that Timeline JS supports "Twitter, Flickr, Google Maps, YouTube, Vimeo, Dailymotion, Wikipedia, SoundCloud" out of the box.

CommentFileSizeAuthor
#5 views_timelinejs-medialink-1855590-5.patch4.7 KBFluxSauce
#3 views_timelinejs-medialink-1855590-3.patch2.82 KBFluxSauce
#3 1855590_make.txt1.4 KBFluxSauce
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

operinko’s picture

operinko CreditAttribution: operinko commented
Status: Active » Needs review

The Link field should be supported by the module already.

operinko’s picture

operinko CreditAttribution: operinko commented

That should be enough to satisfy the "Accept raw URLs" criteria, although it would be very easy to write some sort of support for text fields as well.

But since the Link field already has URL validation built-in, I'm a bit hesitant to extend support for plain text fields.
Sure, every media field goes through a callback function which could and should validate the URL, I'd say it's still duplicate work.

FluxSauce’s picture

FluxSauce CreditAttribution: FluxSauce commented
FileSize
1855590_make.txt1.4 KB
views_timelinejs-medialink-1855590-3.patch2.82 KB

Huh. I could have sworn I tested this and it wasn't working... but then I see you added support for the link field value in 67994829337e7121bab5b85a52a4e7e7da8fdbc5 on December 11 after I submitted this request but before you posted saying it worked. Sneaky ;-)

Now that the link field value is now supported, it sorts the initial problem, but the interface still says "Only image fields are currently supported".

I've attached a patch that addresses the usability issue of the interface and also cleaned up the other labels.

drush make 1855590.make sandbox --prepare-install --yes --no-gitinfofile --no-patch-txt --working-copy
cd sandbox
drush -y si --account-pass=admin --db-url=mysql://root:root@127.0.0.1:9306/sandbox
drush -y en views views_ui link views_timelinejs_feature
drush -y field-delete field_timeline_media_image

Login (admin:admin).

/node/add/timeline-date

/admin/structure/views/view/timeline/edit (Ignore the AJAX errors for now)

  1. Timeline JS settings:
  2. Select field for media asset
  3. Content: Media Link ("Media Link")
operinko’s picture

operinko CreditAttribution: operinko commented

Patch has some errors (mainly stuff like '#title' => ('Headline'), and the same for Body text. That is, it's missing t.).

I'll try to get some work done on the module during this week still :)

FluxSauce’s picture

FluxSauce CreditAttribution: FluxSauce commented
Assigned: Unassigned » FluxSauce
FileSize
views_timelinejs-medialink-1855590-5.patch4.7 KB

Well, that's embarrassing. Good catch! I cleaned up the rest of the form elements as penance.

operinko’s picture

operinko CreditAttribution: operinko commented
Status: Needs review » Fixed

Looks good, committed and attributed.

Automatically closed -- issue fixed for 2 weeks with no activity.