Follow up for #1648930-250: Introduce configuration schema and use for translation 14.
Namespace docs standard fix in core/modules/locale/lib/Drupal/locale/StringStorageInterface.php
Problem/Motivation
Originating issue had changes to this file, but only \namespace style fixes. It was cluttering the issue, and needed to be a follow-up.
Proposed resolution
Go through StringStorageInterface.php and fix it to be correct according to http://drupal.org/node/1354#namespaces
Remaining tasks
- make initial patch of changes, keep focused on only docs and style updates. no refactoring. if refactoring is needed... make it a separate follow-up. :)
- get review
- iterate. patch, review.
Test bot coverage should be sufficient. No manual testing or screenshots needed.
User interface changes
no ui changes.
API changes
no api changes.
Comment | File | Size | Author |
---|---|---|---|
#15 | StringStorageInterface_docfixes-1852288-15.patch | 5.07 KB | underq |
#13 | StringStorageInterface_docfixes-1852288-13.patch | 4.92 KB | underq |
#8 | StringStorageInterface_docfixes-1852288-8.patch | 4.92 KB | underq |
#1 | StringStorageInterface_docfixes-1852288-1.patch | 3.67 KB | aaronott |
Comments
Comment #1
aaronott CreditAttribution: aaronott commentedUpdated docs based on http://drupal.org/node/1354#namespaces
Comment #2
aaronott CreditAttribution: aaronott commentedComment #4
aaronott CreditAttribution: aaronott commented#1: StringStorageInterface_docfixes-1852288-1.patch queued for re-testing.
Comment #5
Gábor HojtsyLooks good to me.
Comment #6
YesCT CreditAttribution: YesCT commented#1: StringStorageInterface_docfixes-1852288-1.patch queued for re-testing.
Comment #8
underq CreditAttribution: underq commentedUpdate patch :)
Comment #9
underq CreditAttribution: underq commentedComment #11
YesCT CreditAttribution: YesCT commentedthis should probably be, if this needs to be rerolled again, \Drupal\locale\...
patches are going in without it though.
Drupal\system\Tests\Upgrade\BlockUpgradePathTest fail probably unrelated.
Comment #12
YesCT CreditAttribution: YesCT commented#8: StringStorageInterface_docfixes-1852288-8.patch queued for re-testing.
Comment #13
underq CreditAttribution: underq commentedReroll as suggested by YesCT :)
Comment #14
gddIt appears we don't have a standard for this, but I actually prefer having the fully qualified object name in the description. Even if we don't make that change, the same object is called a "translation object" here and a "string object" earlier in the patch. It should be consistent.
Otherwise this looks good. Thanks!
Comment #15
underq CreditAttribution: underq commentedI replaced all objects (string, location, translation) with a full qualified object name \Drupal\locale\StringInterface.
I hope this will by ok with you :)
Comment #16
Gábor HojtsyLooks good :) Should not fail since only comment changes.
Comment #17
webchickThis is a docs thing, so moving to that component so Jennifer can have a look.
Comment #18
jhodgdonLooks fine, I'll get it committed shortly. Thanks!
Comment #19
jhodgdonCommitted to 8.x -- thanks again!