Referring to
#1775842: [meta] Convert all variables to state and/or config systems

Converting node_cron_views_scale to state.

Files: 
CommentFileSizeAuthor
#15 convert-statistics-variable-to-state-1831522-14.patch5.04 KBBerdir
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
#14 drupal-convert_statistics_variables_with_tests_and_uninstall-1831522-14.patch5 KBpdrake
PASSED: [[SimpleTest]]: [MySQL] 48,005 pass(es).
[ View ]
#9 drupal-convert_statistics_variables_with_tests_and_uninstall-1831522-9.patch5.01 KBpdrake
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-convert_statistics_variables_with_tests_and_uninstall-1831522-9.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#7 1831522_convert_statistics_variables_with_tests_and_uninstall_7.patch3.2 KBmiro_dietiker
FAILED: [[SimpleTest]]: [MySQL] 47,612 pass(es), 1 fail(s), and 20 exception(s).
[ View ]
#6 1831522_convert_statistics_variables_with_tests_and_uninstall.patch3.19 KBmiro_dietiker
FAILED: [[SimpleTest]]: [MySQL] 47,642 pass(es), 1 fail(s), and 24 exception(s).
[ View ]
#2 1831522_convert_statistics_variables_with_tests.patch2.95 KBmiro_dietiker
FAILED: [[SimpleTest]]: [MySQL] 47,590 pass(es), 1 fail(s), and 20 exception(s).
[ View ]

Comments

alexpott’s picture

Issue tags:+Configuration system

Tagging

miro_dietiker’s picture

Issue tags:-Configuration system
StatusFileSize
new2.95 KB
FAILED: [[SimpleTest]]: [MySQL] 47,590 pass(es), 1 fail(s), and 20 exception(s).
[ View ]

First try.

miro_dietiker’s picture

Status:Active» Needs review
aspilicious’s picture

Can you explain to me what the variable does. I wonder why you reoved the cron part.

Status:Needs review» Needs work

The last submitted patch, 1831522_convert_statistics_variables_with_tests.patch, failed testing.

miro_dietiker’s picture

Status:Needs work» Needs review
StatusFileSize
new3.19 KB
FAILED: [[SimpleTest]]: [MySQL] 47,642 pass(es), 1 fail(s), and 24 exception(s).
[ View ]

Rename was required anyway.
The variable has nothing to do with cron (no related match).

Also added uninstall for state.

miro_dietiker’s picture

Issue tags:+Configuration system
StatusFileSize
new3.2 KB
FAILED: [[SimpleTest]]: [MySQL] 47,612 pass(es), 1 fail(s), and 20 exception(s).
[ View ]

Renamed to fully qualified name, as the other similar issue #1831486: Convert comment variables to config/state

Status:Needs review» Needs work
pdrake’s picture

Status:Needs work» Needs review
StatusFileSize
new5.01 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-convert_statistics_variables_with_tests_and_uninstall-1831522-9.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

This adds another statistics variable to the conversion and hopefully fixes the test.

miro_dietiker’s picture

Looks great! Thanks! :-)

Berdir’s picture

Status:Needs review» Reviewed & tested by the community

Looks good. All those test additionals are going to conflict in ugly way, but it doesn't really matter in which order they get in, most will probably require some re-rolls.

catch’s picture

Status:Reviewed & tested by the community» Needs work
Issue tags:+Configuration system
pdrake’s picture

Status:Needs work» Needs review
StatusFileSize
new5 KB
PASSED: [[SimpleTest]]: [MySQL] 48,005 pass(es).
[ View ]

Fixed merge conflict.

Berdir’s picture

StatusFileSize
new5.04 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Re-roll.

Status:Needs review» Needs work

The last submitted patch, convert-statistics-variable-to-state-1831522-14.patch, failed testing.

Berdir’s picture

Status:Needs work» Reviewed & tested by the community

#14 Looks fine, the only difference to #15 is that we inserted the conflicted bit at a different location. Tstbot needs to confirm of course.

catch’s picture

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks for the quick re-roll.

Automatically closed -- issue fixed for 2 weeks with no activity.