When configuring a handler like a field, filter, or sort, the bottom of every form has a "More" section.

90% of the time, the only thing in there is "Administrative title", which is anticlimactic, but also seems more important than it is.

Original proposed resolution:
We should move everything out of there, and have a #states-based checkbox to toggle the "Administrative title" textfield.

Current proposed resolution:
(needs described) Moves other things out of more, just leaves admin title there.

Next steps:
next step is to rename that fieldset to say Admin title. (See comment #24)

UI Changes:
Yes, see screenshots in the review in #23

Files: 
CommentFileSizeAuthor
#51 nopatch-collapsed.png12.87 KBYesCT
#49 nopatch.png239.49 KBYesCT
#49 collapsed.png211.72 KBYesCT
#49 expanded.png89.89 KBYesCT
#49 more.png271.27 KBYesCT
#49 vdc-1831080-49.patch7.58 KBYesCT
PASSED: [[SimpleTest]]: [MySQL] 56,581 pass(es). View
#49 interdiff-48-49.txt542 bytesYesCT
#48 vdc-1831080-48.patch7.58 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 56,761 pass(es). View
#48 interdiff.txt1.07 KBdawehner
#46 vdc-1831080-46.patch7.55 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 56,961 pass(es), 76 fail(s), and 0 exception(s). View
#46 interdiff.txt1.9 KBdawehner
#44 vdc-1831080-43.patch7.55 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 56,387 pass(es), 78 fail(s), and 60 exception(s). View
#36 drupal-1831080-32.patch7.84 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1831080-32.patch. Unable to apply patch. See the log in the details link for more information. View
#36 interdiff.txt2.58 KBdawehner
#28 drupal-1831080-28.patch6.04 KBIshaDakota
FAILED: [[SimpleTest]]: [MySQL] 56,955 pass(es), 1 fail(s), and 0 exception(s). View
#28 interdiff.txt985 bytesIshaDakota
#28 admin-title.png92.2 KBIshaDakota
#23 MORE_issue_without_patch.png114.13 KBbannockree
#23 more_under_MORE_without_patch.png89.61 KBbannockree
#23 with_patch_admin_title_under_more.png71.63 KBbannockree
#23 with_patch_string_settings_more_issue.png81.17 KBbannockree
#18 more-link.png116.16 KBoresh
#12 drupal-1831080-12.patch8.67 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 55,296 pass(es). View
#9 need_better_title.png22.94 KBdawehner
#9 drupal-1831080-9.patch8.67 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 49,980 pass(es), 1 fail(s), and 0 exception(s). View
#7 drupal-1831080-7.patch5.23 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 50,166 pass(es). View
#1 more-section.png36.77 KBtim.plunkett

Comments

tim.plunkett’s picture

FileSize
36.77 KB

Screenshot of current behavior.

more-section.png

Bojhan’s picture

Issue tags: +BADCamp2012UX
dawehner’s picture

Here is a list of places what the more fieldset is used for:

  • General: Administrative title
  • Node edit link field: Checkbox to add the current view as destination after editing the node.
  • Fieldapi field: Select field to choose on which internal value to clicksort.
  • Has new content field: Checkbox to use new comments additional to new nodes.
  • User link field: Advanced settings how to display the anonymous user
  • Contextual filters: Allow multiple values and some more advanced edge case settings
  • Contextual filters for numbers: Exclude the items instead of include
  • Contextual filters for strings: Glossary options
  • Filters: $Key used in the query, for example ?$key=Value
lirantal’s picture

Not sure on what's the action item on this though?
While original description moved to remove the 'more' fieldset @dawehner shows that it is being used in other places.

lisarex’s picture

So ~80% of the time there's one, maybe 2 items in the More section. I still think it's disruptive more than useful.

Bojhan’s picture

Agreed, and we can just keep it for the few cases there are many?

dawehner’s picture

FileSize
5.23 KB
PASSED: [[SimpleTest]]: [MySQL] 50,166 pass(es). View

The only place in which we currently multiple items are contextual filters. It seems to be that these settings are all pretty much advanced so putting
them in there might make sense. In the issue queue there have been quite some users which haven't been able to find out "how to configure a glossary" so we
might should move these options out into a new fieldset?

I personally would suggest to put in a total different fieldset, to make it clear what can be done there.

For now the admin label is still part of the more fieldset (not sure what to do with it), though if we expose the admin label more visible to the users
we might don't have to add [hidden] to the fields? (just an idea)

Bojhan’s picture

Yhea, I am +1 on putting it in a total different fieldset - labels that represent the content of fieldsets tend to be much better than "more" or "advanced".

dawehner’s picture

FileSize
8.67 KB
FAILED: [[SimpleTest]]: [MySQL] 49,980 pass(es), 1 fail(s), and 0 exception(s). View
22.94 KB

Moved some of the settings into a new fieldset

yoroy’s picture

Status: Active » Needs review

bot?

Status: Needs review » Needs work

The last submitted patch, drupal-1831080-9.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
FileSize
8.67 KB
PASSED: [[SimpleTest]]: [MySQL] 55,296 pass(es). View

Rerolled.

dawehner’s picture

#12: drupal-1831080-12.patch queued for re-testing.

Bojhan’s picture

Status: Needs review » Reviewed & tested by the community

Lets do this!

dawehner’s picture

#12: drupal-1831080-12.patch queued for re-testing.

webchick’s picture

Issue tags: +Needs screenshots

What's the "after" screenshot?

Bojhan’s picture

Status: Reviewed & tested by the community » Needs review

I tried to test this on simplytest.me but it didn't behave as I expected, is this bugged or is it simplytest.me?

oresh’s picture

Status: Needs review » Needs work
FileSize
116.16 KB

I applied the patch, but still get the 'More' label and content inside that area (see image).

dawehner’s picture

If we really want to move out the adminstrative label, then please let's fix #1838010: Remove redundant admin labeling on AreaPluginBase first.

shnark’s picture

The issue #1838010-38: Remove redundant admin labeling on AreaPluginBase was committed a few days ago.
Given that what new direction should this go in?

Bojhan’s picture

Status: Needs work » Needs review

Yup, @dawehner does this need a reroll?

dawehner’s picture

#12: drupal-1831080-12.patch queued for re-testing.

bannockree’s picture

To find out what the patch does, I did the following.
I installed drupal 8 without the patch, went to admin/structure/views and added a view
In the view, I went to Filter Criteria and chose "add"
I chose "Content: Author uid" and clicked Apply
The resulting window had "MORE" as a choice at the bottom; when I clicked on it, the only thing under it was "Administrative Title." This is illustrated in the following screenshot:

MORE_issue_without_patch.png

I then went back to the view window and selected ADVANCED
I went to Contextual Filters and clicked "add"
I chose "Content: body" and clicked Apply
The resulting window had "MORE" at the bottom. When I clicked MORE, "Administrative Title" came up, and so did several other items. These are illustrated in the following screenshot:

more_under_MORE_without_patch.png

I then applied the patch and reinstalled drupal 8.
I repeated the steps to apply the filter criterion "Content: Author uid"
The resulting window still had "MORE" as a choice at the bottom, and when I clicked on it, the only thing under it was still "Administrative Title." This is illustrated in the following screenshot:

with_patch_admin_title_under_more.png

I then repeated the steps to apply the Contextual Filter "Content: body"
The resulting window still had "MORE" as a choice at the bottom. When I clicked on it, the only thing under it was "Administrative Title." The additional items that had been there before the patch was applied were no longer there.

I then went back and saw that a dropdown choice called "STRING SETTINGS" was present. When I clicked on it, the items that had been present under "MORE" before the patch was applied were displayed. This is illustrated in the following screenshot:

with_patch_string_settings_more_issue.png

So as far as I can tell what the patch did was to remove everything except for "Administrative Title" from "MORE" and put them under a more informative heading, but the issue of having the "MORE" dropdown choice with nothing under it except for "Administrative Title" is still present with the patch.

Bojhan’s picture

I'd say the next step is to rename that fieldset to say Admin title?

YesCT’s picture

Issue tags: -Needs screenshots

Thanks @bannockree that write up is excellent. It says what you did in a way that someone else can repeat the steps later if they need to. And those embedded screenshots very well illustrate what is happening before and after the patch.

I took off the needs screenshot tag. We can add it back later if this needs more screenshots.

If the only thing now in that fieldset is going to be admin title, then @Bojhan's suggestion in #24 sounds like enough to get this in.

I'll update the issue summary with the next step.

lisarex’s picture

Is 'Admin title' informative enough? 'Admin' has so many meanings. How about 'Alternative title' instead?

Bojhan’s picture

@lisarex Nope, the fieldset should be "Administrative title". There is nothing alternative, it is the title we use for administrative purposes. It is also the convention to label it like this.

IshaDakota’s picture

FileSize
92.2 KB
985 bytes
6.04 KB
FAILED: [[SimpleTest]]: [MySQL] 56,955 pass(es), 1 fail(s), and 0 exception(s). View

Is this all we wanted: to change the name of the fieldset (see interdiff)? or did we want to remove the fieldset altogether?

Screenshot with this patch applied:
Admin Title with patch

IshaDakota’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, drupal-1831080-28.patch, failed testing.

Bojhan’s picture

We do not want to remove the fieldset, its often not relevant - having it in a collapsed fieldset for that purpose is fine.

Bojhan’s picture

Issue tags: +sprint

tagging

klonos’s picture

Issue tags: -sprint

Having a single element hidden in a fieldset is pointless IMO. Bad UX and waste of space if you ask me.

Bojhan’s picture

Issue tags: +sprint

@klonos Its not, this is the exact reason why collapsible fieldsets exist. Its to hide something that is not always relevant, but does offer useful functionality and exposing it would lead to distraction. Could we make it better and find a different location (e.g. redesign the whole admin title interaction)? We could but I think this is a great intermediate step, if you want to push to a great fix please open a new/followup issue - as I think thats more appropriate given the time its taken to get this as far as it is.

klonos’s picture

...don't know why that tag was removed. Sorry :/

As for my comment, I was speaking in general - it was not meant for this specific use case only. Fieldsets AFAIK are used to group things together. That is their main function. There's no point in grouping a single item by itself. The ability that fieldsets have to be collapsed can be used to hide distracting/confusing things away, but that is a secondary function IMO.

If we want to reduce importance we could simply have a label read "Optional administrative title" or "Administrative title (optional)"

dawehner’s picture

Status: Needs work » Needs review
Issue tags: -sprint
FileSize
2.58 KB
7.84 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-1831080-32.patch. Unable to apply patch. See the log in the details link for more information. View

Let's do it properly.

Status: Needs review » Needs work

The last submitted patch, drupal-1831080-32.patch, failed testing.

Bojhan’s picture

@klonos I agree its a secondary purpose. We shouldn't put fieldsets around single things, but in this case its the only pattern to make it less important.

klonos’s picture

Yep, I see that. I was just brainstorming over this. I'm currently taking a look at all the places this issue effects (these mentioned in #3). I'll post here if I come up with something useful/worthwhile.

lisarex’s picture

From the original testing we did, we observed people clicking the More fieldset open, puzzling, then moving on. They were disappointed that it wasn't anything more exciting :) The More fieldset was a detractor from completing the task... collapsed fieldset in and of itself didn't reduce importance because the label was so mysterious.

However, a collapsed fieldset with a clear label will at least mean people can skim past without worrying they're missing out, so that's good.

What about the other options in #3? What fieldset label will they be under? I'm not clear from reading these comments over and over again.

Bojhan’s picture

I think most of them are moved under a specialised fieldset called "Filter identifier"

dawehner’s picture

Status: Needs work » Needs review
Issue tags: -Usability, -Novice, -VDC, -BADCamp2012UX

#36: drupal-1831080-32.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Usability, +Novice, +VDC, +BADCamp2012UX

The last submitted patch, drupal-1831080-32.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
FileSize
7.55 KB
FAILED: [[SimpleTest]]: [MySQL] 56,387 pass(es), 78 fail(s), and 60 exception(s). View

Just another rerole.

Status: Needs review » Needs work

The last submitted patch, vdc-1831080-43.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
FileSize
1.9 KB
7.55 KB
FAILED: [[SimpleTest]]: [MySQL] 56,961 pass(es), 76 fail(s), and 0 exception(s). View
  • Fixed the test failures
  • The more fieldset is now automatically hidden, if nothing is in there.

Status: Needs review » Needs work

The last submitted patch, vdc-1831080-46.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
FileSize
1.07 KB
7.58 KB
PASSED: [[SimpleTest]]: [MySQL] 56,761 pass(es). View

Fixed the test failures.

YesCT’s picture

FileSize
542 bytes
7.58 KB
PASSED: [[SimpleTest]]: [MySQL] 56,581 pass(es). View
271.27 KB
89.89 KB
211.72 KB
239.49 KB

I looked at the whole patch. looks good. there was one little thing in a comment, so I just fixed it.

+++ b/core/modules/views_ui/admin.incundefined
@@ -275,6 +275,15 @@ function views_ui_pre_render_add_fieldset_markup($form) {
+  // Hide the fieldsets if there is nothing on there.

in there

tried it before and after the patch. looks good.
it moves administrative title to it's own fieldset, and in most cases that means there is no "more" fieldset.

no patch

collapsed

nopatch-collapsed.png

expanded

nopatch.png

patch

collapsed

collapsed.png

expanded

expanded.png

contextual filters (other stuff than admin title)

more.png

YesCT’s picture

Status: Needs review » Reviewed & tested by the community

if it's green, I think this is a good improvement.

YesCT’s picture

FileSize
12.87 KB

I forgot one of the no-patch screenshots which shows it collapsed.
putting it in comment #50

dawehner’s picture

Opened a follow up to fix some of the fieldset styling: #2033067: Fieldsets in views modals don't look good

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed d03acd3 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

added next steps.