When configuring a handler like a field, filter, or sort, the bottom of every form has a "More" section.
90% of the time, the only thing in there is "Administrative title", which is anticlimactic, but also seems more important than it is.
Original proposed resolution:
We should move everything out of there, and have a #states-based checkbox to toggle the "Administrative title" textfield.
Current proposed resolution:
(needs described) Moves other things out of more, just leaves admin title there.
Next steps:
next step is to rename that fieldset to say Admin title. (See comment #24)
UI Changes:
Yes, see screenshots in the review in #23
Comment | File | Size | Author |
---|---|---|---|
#51 | nopatch-collapsed.png | 12.87 KB | YesCT |
#49 | nopatch.png | 239.49 KB | YesCT |
#49 | collapsed.png | 211.72 KB | YesCT |
#49 | expanded.png | 89.89 KB | YesCT |
#49 | more.png | 271.27 KB | YesCT |
Comments
Comment #1
tim.plunkettScreenshot of current behavior.
Comment #2
Bojhan CreditAttribution: Bojhan commentedComment #3
dawehnerHere is a list of places what the more fieldset is used for:
Comment #4
lirantal CreditAttribution: lirantal commentedNot sure on what's the action item on this though?
While original description moved to remove the 'more' fieldset @dawehner shows that it is being used in other places.
Comment #5
lisarex CreditAttribution: lisarex commentedSo ~80% of the time there's one, maybe 2 items in the More section. I still think it's disruptive more than useful.
Comment #6
Bojhan CreditAttribution: Bojhan commentedAgreed, and we can just keep it for the few cases there are many?
Comment #7
dawehnerThe only place in which we currently multiple items are contextual filters. It seems to be that these settings are all pretty much advanced so putting
them in there might make sense. In the issue queue there have been quite some users which haven't been able to find out "how to configure a glossary" so we
might should move these options out into a new fieldset?
I personally would suggest to put in a total different fieldset, to make it clear what can be done there.
For now the admin label is still part of the more fieldset (not sure what to do with it), though if we expose the admin label more visible to the users
we might don't have to add [hidden] to the fields? (just an idea)
Comment #8
Bojhan CreditAttribution: Bojhan commentedYhea, I am +1 on putting it in a total different fieldset - labels that represent the content of fieldsets tend to be much better than "more" or "advanced".
Comment #9
dawehnerMoved some of the settings into a new fieldset
Comment #10
yoroy CreditAttribution: yoroy commentedbot?
Comment #12
dawehnerRerolled.
Comment #13
dawehner#12: drupal-1831080-12.patch queued for re-testing.
Comment #14
Bojhan CreditAttribution: Bojhan commentedLets do this!
Comment #15
dawehner#12: drupal-1831080-12.patch queued for re-testing.
Comment #16
webchickWhat's the "after" screenshot?
Comment #17
Bojhan CreditAttribution: Bojhan commentedI tried to test this on simplytest.me but it didn't behave as I expected, is this bugged or is it simplytest.me?
Comment #18
oresh CreditAttribution: oresh commentedI applied the patch, but still get the 'More' label and content inside that area (see image).
Comment #19
dawehnerIf we really want to move out the adminstrative label, then please let's fix #1838010: Remove redundant admin labeling on AreaPluginBase first.
Comment #20
shnark CreditAttribution: shnark commentedThe issue #1838010-38: Remove redundant admin labeling on AreaPluginBase was committed a few days ago.
Given that what new direction should this go in?
Comment #21
Bojhan CreditAttribution: Bojhan commentedYup, @dawehner does this need a reroll?
Comment #22
dawehner#12: drupal-1831080-12.patch queued for re-testing.
Comment #23
bannockree CreditAttribution: bannockree commentedTo find out what the patch does, I did the following.
I installed drupal 8 without the patch, went to admin/structure/views and added a view
In the view, I went to Filter Criteria and chose "add"
I chose "Content: Author uid" and clicked Apply
The resulting window had "MORE" as a choice at the bottom; when I clicked on it, the only thing under it was "Administrative Title." This is illustrated in the following screenshot:
I then went back to the view window and selected ADVANCED
I went to Contextual Filters and clicked "add"
I chose "Content: body" and clicked Apply
The resulting window had "MORE" at the bottom. When I clicked MORE, "Administrative Title" came up, and so did several other items. These are illustrated in the following screenshot:
I then applied the patch and reinstalled drupal 8.
I repeated the steps to apply the filter criterion "Content: Author uid"
The resulting window still had "MORE" as a choice at the bottom, and when I clicked on it, the only thing under it was still "Administrative Title." This is illustrated in the following screenshot:
I then repeated the steps to apply the Contextual Filter "Content: body"
The resulting window still had "MORE" as a choice at the bottom. When I clicked on it, the only thing under it was "Administrative Title." The additional items that had been there before the patch was applied were no longer there.
I then went back and saw that a dropdown choice called "STRING SETTINGS" was present. When I clicked on it, the items that had been present under "MORE" before the patch was applied were displayed. This is illustrated in the following screenshot:
So as far as I can tell what the patch did was to remove everything except for "Administrative Title" from "MORE" and put them under a more informative heading, but the issue of having the "MORE" dropdown choice with nothing under it except for "Administrative Title" is still present with the patch.
Comment #24
Bojhan CreditAttribution: Bojhan commentedI'd say the next step is to rename that fieldset to say Admin title?
Comment #25
YesCT CreditAttribution: YesCT commentedThanks @bannockree that write up is excellent. It says what you did in a way that someone else can repeat the steps later if they need to. And those embedded screenshots very well illustrate what is happening before and after the patch.
I took off the needs screenshot tag. We can add it back later if this needs more screenshots.
If the only thing now in that fieldset is going to be admin title, then @Bojhan's suggestion in #24 sounds like enough to get this in.
I'll update the issue summary with the next step.
Comment #26
lisarex CreditAttribution: lisarex commentedIs 'Admin title' informative enough? 'Admin' has so many meanings. How about 'Alternative title' instead?
Comment #27
Bojhan CreditAttribution: Bojhan commented@lisarex Nope, the fieldset should be "Administrative title". There is nothing alternative, it is the title we use for administrative purposes. It is also the convention to label it like this.
Comment #28
IshaDakota CreditAttribution: IshaDakota commentedIs this all we wanted: to change the name of the fieldset (see interdiff)? or did we want to remove the fieldset altogether?
Screenshot with this patch applied:
Comment #29
IshaDakota CreditAttribution: IshaDakota commentedComment #31
Bojhan CreditAttribution: Bojhan commentedWe do not want to remove the fieldset, its often not relevant - having it in a collapsed fieldset for that purpose is fine.
Comment #32
Bojhan CreditAttribution: Bojhan commentedtagging
Comment #33
klonosHaving a single element hidden in a fieldset is pointless IMO. Bad UX and waste of space if you ask me.
Comment #34
Bojhan CreditAttribution: Bojhan commented@klonos Its not, this is the exact reason why collapsible fieldsets exist. Its to hide something that is not always relevant, but does offer useful functionality and exposing it would lead to distraction. Could we make it better and find a different location (e.g. redesign the whole admin title interaction)? We could but I think this is a great intermediate step, if you want to push to a great fix please open a new/followup issue - as I think thats more appropriate given the time its taken to get this as far as it is.
Comment #35
klonos...don't know why that tag was removed. Sorry :/
As for my comment, I was speaking in general - it was not meant for this specific use case only. Fieldsets AFAIK are used to group things together. That is their main function. There's no point in grouping a single item by itself. The ability that fieldsets have to be collapsed can be used to hide distracting/confusing things away, but that is a secondary function IMO.
If we want to reduce importance we could simply have a label read "Optional administrative title" or "Administrative title (optional)"
Comment #36
dawehnerLet's do it properly.
Comment #38
Bojhan CreditAttribution: Bojhan commented@klonos I agree its a secondary purpose. We shouldn't put fieldsets around single things, but in this case its the only pattern to make it less important.
Comment #39
klonosYep, I see that. I was just brainstorming over this. I'm currently taking a look at all the places this issue effects (these mentioned in #3). I'll post here if I come up with something useful/worthwhile.
Comment #40
lisarex CreditAttribution: lisarex commentedFrom the original testing we did, we observed people clicking the More fieldset open, puzzling, then moving on. They were disappointed that it wasn't anything more exciting :) The More fieldset was a detractor from completing the task... collapsed fieldset in and of itself didn't reduce importance because the label was so mysterious.
However, a collapsed fieldset with a clear label will at least mean people can skim past without worrying they're missing out, so that's good.
What about the other options in #3? What fieldset label will they be under? I'm not clear from reading these comments over and over again.
Comment #41
Bojhan CreditAttribution: Bojhan commentedI think most of them are moved under a specialised fieldset called "Filter identifier"
Comment #42
dawehner#36: drupal-1831080-32.patch queued for re-testing.
Comment #44
dawehnerJust another rerole.
Comment #46
dawehnerComment #48
dawehnerFixed the test failures.
Comment #49
YesCT CreditAttribution: YesCT commentedI looked at the whole patch. looks good. there was one little thing in a comment, so I just fixed it.
in there
tried it before and after the patch. looks good.
it moves administrative title to it's own fieldset, and in most cases that means there is no "more" fieldset.
no patch
collapsed
expanded
patch
collapsed
expanded
contextual filters (other stuff than admin title)
Comment #50
YesCT CreditAttribution: YesCT commentedif it's green, I think this is a good improvement.
Comment #51
YesCT CreditAttribution: YesCT commentedI forgot one of the no-patch screenshots which shows it collapsed.
putting it in comment #50
Comment #52
dawehnerOpened a follow up to fix some of the fieldset styling: #2033067: Fieldsets in views modals don't look good
Comment #53
alexpottCommitted d03acd3 and pushed to 8.x. Thanks!
Comment #54.0
(not verified) CreditAttribution: commentedadded next steps.