Files: 
CommentFileSizeAuthor
#20 1831076-omit_vary_to_config-drupal8-20.patch2.01 KBACF
PASSED: [[SimpleTest]]: [MySQL] 49,408 pass(es). View
#17 1831076-omit_vary_to_config-drupal8-17.patch2 KBACF
PASSED: [[SimpleTest]]: [MySQL] 49,316 pass(es). View
#14 1831076-omit_vary_to_config-drupal8-14.patch2.12 KBACF
PASSED: [[SimpleTest]]: [MySQL] 49,421 pass(es). View
#11 1831076-omit_vary_to_config-drupal8-11.patch2.12 KBACF
PASSED: [[SimpleTest]]: [MySQL] 49,226 pass(es). View
#8 1831076-omit_vary_to_config-drupal8-8.patch2.12 KBACF
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/system/system.install. View
#7 1831076-omit_vary_to_config-drupal8-7.patch2.12 KBACF
PASSED: [[SimpleTest]]: [MySQL] 49,272 pass(es). View
#5 1831076-omit_vary_to_config-drupal8-5.patch2.12 KBACF
PASSED: [[SimpleTest]]: [MySQL] 49,279 pass(es). View
#3 1831076-omit_vary_to_config-drupal8-3.patch1.52 KBACF
PASSED: [[SimpleTest]]: [MySQL] 48,972 pass(es). View
omit_vary_cookie_cmi.patch2.26 KBAlbert Volkman
FAILED: [[SimpleTest]]: [MySQL] 46,926 pass(es), 2 fail(s), and 0 exception(s). View

Comments

Albert Volkman’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, omit_vary_cookie_cmi.patch, failed testing.

ACF’s picture

Status: Needs work » Needs review
FileSize
1.52 KB
PASSED: [[SimpleTest]]: [MySQL] 48,972 pass(es). View

Not sure if the TRUE in default.settings.php is correct or if it should be 1.

aspilicious’s picture

Status: Needs review » Needs work

TRUE looks ok but we need an update function for cmi variables.

ACF’s picture

Status: Needs work » Needs review
FileSize
2.12 KB
PASSED: [[SimpleTest]]: [MySQL] 49,279 pass(es). View

updated with that change.

aspilicious’s picture

Status: Needs review » Needs work
+++ b/core/modules/system/system.installundefined
@@ -2305,6 +2305,18 @@ function system_update_8039() {
+}
+
+
+/**

Can we remove 1 newline here.

+++ b/sites/default/default.settings.phpundefined
@@ -444,7 +444,7 @@
-# $conf['omit_vary_cookie'] = TRUE;
+# $conf['system.performance']['cache.page.omit_vary_cookie'] = TRUE;
 
 /**
  * CSS/JS aggregated file gzip compression:

I'm prety sure it needs to be # $conf['system.performance']['cache']['page']['omit_vary_cookie'] = TRUE;

The first two elements are a key the last ones are array elements

ACF’s picture

Status: Needs work » Needs review
FileSize
2.12 KB
PASSED: [[SimpleTest]]: [MySQL] 49,272 pass(es). View

Looking at some of the other variables in default.settings.php I think it works either way, unless they are wrong too.

ACF’s picture

FileSize
2.12 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/system/system.install. View

re-roll

Status: Needs review » Needs work

The last submitted patch, 1831076-omit_vary_to_config-drupal8-8.patch, failed testing.

Albert Volkman’s picture

system_update_N() duplicate.

ACF’s picture

Status: Needs work » Needs review
FileSize
2.12 KB
PASSED: [[SimpleTest]]: [MySQL] 49,226 pass(es). View

stupid error.

Status: Needs review » Needs work

The last submitted patch, 1831076-omit_vary_to_config-drupal8-11.patch, failed testing.

ACF’s picture

Status: Needs work » Needs review
ACF’s picture

FileSize
2.12 KB
PASSED: [[SimpleTest]]: [MySQL] 49,421 pass(es). View

rerolled to update system number.

Status: Needs review » Needs work

The last submitted patch, 1831076-omit_vary_to_config-drupal8-14.patch, failed testing.

ACF’s picture

Status: Needs work » Needs review
ACF’s picture

FileSize
2 KB
PASSED: [[SimpleTest]]: [MySQL] 49,316 pass(es). View

re-rolled again.

ACF’s picture

re-rolled again.

aspilicious’s picture

Status: Needs review » Needs work

Did you test it? I did with the incorrect settings.php stuff currently in core:

#1873008: Settings.php conf overrides are incorrect

ACF’s picture

Status: Needs work » Needs review
FileSize
2.01 KB
PASSED: [[SimpleTest]]: [MySQL] 49,408 pass(es). View

change made.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Great :)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.