Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#20 | 1831076-omit_vary_to_config-drupal8-20.patch | 2.01 KB | ACF |
#17 | 1831076-omit_vary_to_config-drupal8-17.patch | 2 KB | ACF |
#14 | 1831076-omit_vary_to_config-drupal8-14.patch | 2.12 KB | ACF |
#11 | 1831076-omit_vary_to_config-drupal8-11.patch | 2.12 KB | ACF |
#8 | 1831076-omit_vary_to_config-drupal8-8.patch | 2.12 KB | ACF |
Comments
Comment #1
Albert Volkman CreditAttribution: Albert Volkman commentedComment #3
ACF CreditAttribution: ACF commentedNot sure if the TRUE in default.settings.php is correct or if it should be 1.
Comment #4
aspilicious CreditAttribution: aspilicious commentedTRUE looks ok but we need an update function for cmi variables.
Comment #5
ACF CreditAttribution: ACF commentedupdated with that change.
Comment #6
aspilicious CreditAttribution: aspilicious commentedCan we remove 1 newline here.
I'm prety sure it needs to be # $conf['system.performance']['cache']['page']['omit_vary_cookie'] = TRUE;
The first two elements are a key the last ones are array elements
Comment #7
ACF CreditAttribution: ACF commentedLooking at some of the other variables in default.settings.php I think it works either way, unless they are wrong too.
Comment #8
ACF CreditAttribution: ACF commentedre-roll
Comment #10
Albert Volkman CreditAttribution: Albert Volkman commentedsystem_update_N() duplicate.
Comment #11
ACF CreditAttribution: ACF commentedstupid error.
Comment #13
ACF CreditAttribution: ACF commented#11: 1831076-omit_vary_to_config-drupal8-11.patch queued for re-testing.
Comment #14
ACF CreditAttribution: ACF commentedrerolled to update system number.
Comment #16
ACF CreditAttribution: ACF commented#14: 1831076-omit_vary_to_config-drupal8-14.patch queued for re-testing.
Comment #17
ACF CreditAttribution: ACF commentedre-rolled again.
Comment #18
ACF CreditAttribution: ACF commentedre-rolled again.
Comment #19
aspilicious CreditAttribution: aspilicious commentedDid you test it? I did with the incorrect settings.php stuff currently in core:
#1873008: Settings.php conf overrides are incorrect
Comment #20
ACF CreditAttribution: ACF commentedchange made.
Comment #21
aspilicious CreditAttribution: aspilicious commentedGreat :)
Comment #22
webchickCommitted and pushed to 8.x. Thanks!