On our site, Drupal.org, spot checking the DB structure and variables, it looks like all updates in apachesolr.install are not needed at this time. Some throw errors trying to update things which already have been updated.

CommentFileSizeAuthor
#6 1827320-d6.patch1.04 KBdrumm
#6 1827320-d7.patch7.16 KBdrumm
#3 1827320-d6.patch743 bytesdrumm
#3 1827320-d7.patch6.83 KBdrumm

Comments

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

There is no upgrade path from 6.x-3.x to 7.x-1.x yet. Any suggestions on how to resolve this?

drumm’s picture

drumm
he/him
Location NY, US
commented
Issue tags: +search, +drupal.org D7

What changes are needed for this upgrade path? apachesolr_schema() in 6.x-3.x and 7.x-1.x are the same. I haven't done an exhaustive check of variables, but apachesolr_index_updated looks like it would after apachesolr_update_7012(), an array of ints rather than a single int.

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new 1827320-d7.patch6.83 KB
new 1827320-d6.patch743 bytes

Here is an idea for how to support this. apachesolr_update_6303() sets a flag used in 7.x updates.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Needs review
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Needs work

So there is no drupal mechanism at all to do this aside from a variable? If we add this variable we should also remove it on uninstall

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs work » Needs review
StatusFileSize
new 1827320-d7.patch7.16 KB
new 1827320-d6.patch1.04 KB

Attached are versions adding removal on uninstall.

Core only runs a module's updates in order and doesn't have a mechanism I'm aware of to make this nicer. Temporary variables to hold state for updates happens, such as system_update_6043_RC2 in http://drupalcode.org/project/drupal.git/blob/refs/heads/6.x:/modules/sy....

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Fixed

commited to both branches, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

andrewsuth’s picture

andrewsuth commented

On the module page is says

6.x-3.x: Full backport of the 7.x-1.x branch. Features all functionality of 7.x-1.x. This version is currently in use by Drupal.org! So it is certainly stable enough to begin your D6 to D7 upgrade with. There is a limited upgrade path included.

Does this patch made to the 6.x-3.x branch mean that there is now a full upgrade path from 6.x-3.x to 7.x-1.x?

If you were to choose a install either 6.x-1.x or 6.x-3.x today (with the intention of upgrading to 7.x in the next 12 months), which one would you install?