Adding these attributes to images helps the browser arrange the page more quickly. Since we're just using the default size, that will be 48x48.

CommentFileSizeAuthor
#10 twitter-n1825680-9.patch1.03 KBdamienmckenna
#6 twitter-n1825680-6.patch1.02 KBdamienmckenna
#5 twitter-n1825680-5.patch1.02 KBdamienmckenna
#1 1825680-twitter-profile_image-size.patch1.01 KBlyricnz

Comments

lyricnz’s picture

lyricnz commented
Status: Active » Needs review
StatusFileSize
new 1825680-twitter-profile_image-size.patch1.01 KB

Attached

lyricnz’s picture

lyricnz commented

If #1828732: Allow local caching/processing of profile images gets applied, then themers can implement a theme_twitter_profile_image() to add width/height tags, rather than hacking twitter code.

13rac1’s picture

13rac1 commented
Version: 7.x-3.x-dev » 7.x-5.x-dev
Status: Needs review » Reviewed & tested by the community

Patch applies to 7.x-5.x! I agree, this simple change will speed up page render.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
Parent issue: » #2402307: Plan for Twitter v7.x-5.9 release

Triggering the testbot.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.x-dev » 7.x-6.x-dev
StatusFileSize
new twitter-n1825680-5.patch1.02 KB

I've changed it to a render array and ported it to the 7.x-6.x branch.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-6.x-dev » 7.x-5.x-dev
StatusFileSize
new twitter-n1825680-6.patch1.02 KB

For the 7.x-5.x branch.

  • DamienMcKenna committed 52a21ec on 7.x-6.x authored by lyricnz 
    Issue #1825680 by lyricnz, DamienMcKenna: Add width/height attributes to...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed to both the 7.x-5.x and 7.x-6.x branches.

  • DamienMcKenna committed 9e20ed0 on 7.x-5.x 
    Issue #1825680 by lyricnz, DamienMcKenna: Add width/height attributes to...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.x-dev » 6.x-5.x-dev
Related issues: +#2402311: Plan for Twitter v6.x-5.2 release, +#2402309: Plan for Twitter v7.x-6.0 release
StatusFileSize
new twitter-n1825680-9.patch1.03 KB

Here's a port to the 6.x-5.x branch.

  • DamienMcKenna committed d656045 on 6.x-5.x 
    Issue #1825680 by lyricnz, DamienMcKenna: Add width/height attributes to...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I've also committed the patch to the 6.x-5.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.