Need to add template_preprocess and template file in stark theme template folder.

CommentFileSizeAuthor
#9 fixing-syntax-error-converting_theme_filter_admin_format_filter_order_to_twig-1823158-7.patch775 bytesartofeclipse
#6 converting_theme_filter_admin_format_filter_order_to_twig-1823158-6.patch2.9 KBartofeclipse
#3 converting_theme_filter_admin_format_filter_order_to_twig-1823158-3.patch1.82 KBartofeclipse
#1 converting_theme_filter_admin_format_filter_order_to_twig-1823158-1.patch2.9 KBartofeclipse
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

artofeclipse’s picture

artofeclipse CreditAttribution: artofeclipse commented
Status: Active » Needs review
FileSize
converting_theme_filter_admin_format_filter_order_to_twig-1823158-1.patch2.9 KB

hope the the git patch is good :)

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
CreditAttribution: vlad.dancer commented
Status: Needs review » Needs work 
+++ b/core/themes/stark/templates/filter/filter-admin-format-filter-order.html.twig
@@ -0,0 +1,17 @@
+ ¶
\ No newline at end of file
--

Clean typo, pls)

BTW, there is one notice about current preprocess_table func state.

See my comment.

artofeclipse’s picture

artofeclipse CreditAttribution: artofeclipse commented
FileSize
converting_theme_filter_admin_format_filter_order_to_twig-1823158-3.patch1.82 KB

I have made a note of preprocess_table, and I fixed the typo issue, hope this patch is good :)

artofeclipse’s picture

artofeclipse CreditAttribution: artofeclipse commented
Status: Needs work » Needs review

sorry forgot to change the status

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Needs work

#3

git apply --check converting_theme_filter_admin_format_filter_order_to_twig-1823158-3.patch
error: patch failed: core/modules/filter/filter.module:92
error: core/modules/filter/filter.module: patch does not apply
error: core/themes/stark/templates/filter/filter-admin-format-filter-order.html.twig: No such file or directory
artofeclipse’s picture

artofeclipse CreditAttribution: artofeclipse commented
Status: Needs work » Needs review
FileSize
converting_theme_filter_admin_format_filter_order_to_twig-1823158-6.patch2.9 KB

sorry I thought you will review the tow patchs

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented

thanks!!!

commited / pushed #6 to front-end

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Fixed

status

artofeclipse’s picture

artofeclipse CreditAttribution: artofeclipse commented
FileSize
fixing-syntax-error-converting_theme_filter_admin_format_filter_order_to_twig-1823158-7.patch775 bytes

Sorry my previous patch had syntax error, the attached patch is to fix it.

artofeclipse’s picture

artofeclipse CreditAttribution: artofeclipse commented
Status: Fixed » Needs review
vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
CreditAttribution: vlad.dancer commented
Status: Needs review » Reviewed & tested by the community

typo fixed

artofeclipse’s picture

artofeclipse CreditAttribution: artofeclipse commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.