Make render time performance metric accessible in hook_views_post_render()

You can look it up on the view object: $view->render_time.

Mh good point.

I'm wondering whether hook_views_post_render should maybe fired after measuring the render_time, do you have an oppinion about that?

One thing you could do, but pssst you could alter the $view object and maybe replace it
with a decorator version/ a which which extends the normal view class.

If you do this you could fire some hook or something similar later.

At least at the moment probably not may people are using the render time on actual live installations, but just in the admin interface
, so it seems to be safe for me to move this property up. With this hook_views_pre_view and hook_views_post_render you could
even build your own measurement, just throwing out some ideas.
We have considered to remove this property totally for live-views in d8, but that's not decided/done yet, but it's good
to know an actual usecase.

Regarding the decorator idea, here is a short codesnippet. I'm not sure about the performance implications, but they simply can't be positive :) Once you have this decorator in place, you can change the way for example the render method works.

class foo {
  var $test;
}

class fooDecorator {
  var $foo;
  public function __construct(foo $foo) {
    $this->foo = $foo;
  }
   public function __get($key) {
     return $this->foo->{$key};
   }
   public function __set($key, $value) {
     $this->foo->{$key} = $value;
   }
  public function __call($method, $args) {
    return call_user_func_array(array($this->foo, $method), $args);
  }
}

$foo = new foo();
$foo->test = 123;

replace($foo);

dsm($foo->test);

function replace(&$foo) {
  $foo = new fooDecorator($foo);
}

Committed this patch to 7.x-3.x

In drupal8 we actually try to remove this completly because we nether thought that this will be used on the actual live site, see #1811982: Remove ui preview logic viewExecuteable::render() and move it to viewUI. Your oppinion. is greatly appreciated.

I see the point totally, but in theory your module could use the views hooks to start/end some timing on the view object.
It seems to be that you vote against removing this part out of the actual executing of a view, maybe we should make it optional?

This appears to already be before hook_views_post_build() in D8.

\Drupal\views\ViewExecutable line #1195:

    $this->built = TRUE;
    $this->build_time = microtime(TRUE) - $start;

    // Attach displays
    $this->attachDisplays();

    // Let modules modify the view just after building it.
    $module_handler->invokeAll('views_post_build', array($this));

    return TRUE;

I guess the "render time" is now pretty much fucked up on Drupal 8, given that the actual rendering happens late via render API, so its kinda hard to measure it, especially once
we move more and more into post_render_callbacks and what not.

Working on the backport to version 7.x

Working on the backport to version 7.x

@dhrjgpt2005
You don't have this, this was committed to 7.x-3.x already.
This issue is about porting the patch to 8.0.x

@dawehner Could i go ahead with the porting the patch to 8.0.x ?

@dawehner Could you please help me on this. As i am new to this community and would like to be a part to community?

@dawehner it seems that the patch is already there in 8.3.x, with $this->build_time is already there. Please suggest if we still need this.

Oh yeah that should be fine now. we apply this now inside \Drupal\views_ui\ViewUI.

Thank you for bringing this up.