Just found this user_access('access own webform results', $account) with $account not defined.

Patch attached.

CommentFileSizeAuthor
#4 webform-1803808-4.patch983 bytespjcdawkins
0001-Removing-undefined-and-unnecessary-variable.patch927 byteseltermann
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bxtaylor’s picture

bxtaylor CreditAttribution: bxtaylor commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly.

The breadcrumb still functions properly for users with the 'access own webform results' permission.

karl qin’s picture

karl qin CreditAttribution: karl qin commented

patch solves the problem

Shawn DeArmond’s picture

Shawn DeArmond CreditAttribution: Shawn DeArmond commented

Confirmed again. +1

pjcdawkins’s picture

pjcdawkins CreditAttribution: pjcdawkins commented
Status: Reviewed & tested by the community » Needs review
FileSize
webform-1803808-4.patch983 bytes

Can we also fix another problem with the same function, involving cases where $breadcrumb starts off empty? Webform was adding an empty breadcrumb item.

froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
CreditAttribution: froboy commented

Worked for me too.

Shawn DeArmond’s picture

Shawn DeArmond CreditAttribution: Shawn DeArmond commented
Status: Needs review » Reviewed & tested by the community

@pjcdawkins, that is out of scope for this particular issue. Please file a different issue.

OP's patch is RTBC.

Jerenus’s picture

Jerenus CreditAttribution: Jerenus commented

work for me.

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Status: Reviewed & tested by the community » Fixed

Thanks guys! Committed to D7 3.x and 4.x branches. Doesn't seem to affect 6.x-3.x.

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented

BTW I included @pjcdawkins's patch in #4, as it didn't do any harm that I could see.

pjcdawkins’s picture

pjcdawkins CreditAttribution: pjcdawkins commented

Thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tigertrussell’s picture

tigertrussell CreditAttribution: tigertrussell commented

Did this not make it into the latest version of Webform? I see a patch marked RTBC in Oct 2012... it's 2014 now and the lines of the patch don't match up, so I can only assume that this is a different version... yet the patch isn't applied.