Files: 
CommentFileSizeAuthor
#10 1798880-convert-teaser_length-to-CMI-3.patch1.24 KBmtunay
FAILED: [[SimpleTest]]: [MySQL] 46,104 pass(es), 15 fail(s), and 15 exception(s).
[ View ]
#9 1798880-9-convert-teaser_length-to-CMI.patch1.53 KBLinL
PASSED: [[SimpleTest]]: [MySQL] 46,416 pass(es).
[ View ]
#3 1798880-convert-teaser_length-to-CMI.patch1017 bytesandyceo
PASSED: [[SimpleTest]]: [MySQL] 46,200 pass(es).
[ View ]

Comments

LinL’s picture

Title:Convert teaser_length to use state system» Convert teaser_length to use configuration system
Assigned:LinL» Unassigned

Changing title - it is configuration not state.

larowlan’s picture

Tagging

andyceo’s picture

StatusFileSize
new1017 bytes
PASSED: [[SimpleTest]]: [MySQL] 46,200 pass(es).
[ View ]

I think it is good time to breake the backward compatibility with variable 'teaser_length', that goes from Drupal 6.

IMHO, more suitable name for this config is 'default_summary_length', because:
1. It is summary length
2. It is default, because this setting is given when Drupal has no any information about "text field with summary" summary length. This happens when user create a "text field with summary" and didn't setup its widget settings. So, if administrator want, he can update this 'default_summary_length' config, so any new and not-configured "text field with summary" fields will use it.

andyceo’s picture

Status:Active» Needs review

Sorry, forgot to change issue status for testbot.

andyceo’s picture

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community

Looks good

catch’s picture

Status:Reviewed & tested by the community» Needs work

This is missing the upgrade path isn't it?

aspilicious’s picture

You're so right!

LinL’s picture

Status:Needs work» Needs review
StatusFileSize
new1.53 KB
PASSED: [[SimpleTest]]: [MySQL] 46,416 pass(es).
[ View ]

Re-rolled and added update function.

mtunay’s picture

StatusFileSize
new1.24 KB
FAILED: [[SimpleTest]]: [MySQL] 46,104 pass(es), 15 fail(s), and 15 exception(s).
[ View ]

I added the update hook...

LinL’s picture

Following on from the name change here:

teaser_length to default_summary_length

I'm wondering if a similar change should be made in aggregator?

EDIT: I've added this issue: #1830068: Change teaser_length to default_summary_length in aggregator?

LinL’s picture

Oops, cross-post :)

Status:Needs review» Needs work
Issue tags:-Configuration system, -#pnx-sprint

The last submitted patch, 1798880-convert-teaser_length-to-CMI-3.patch, failed testing.

LinL’s picture

Status:Needs work» Needs review
mtunay’s picture

mtunay’s picture

sorry, have forgotten the config.yml file. LinL post works fine.. Thanks.

aspilicious’s picture

mtunay, please don't retest your file. It is missing the .yml file. If the patch from LinL comes back green that one is rtbc.

Status:Needs review» Needs work

The last submitted patch, 1798880-convert-teaser_length-to-CMI-3.patch, failed testing.

LinL’s picture

Status:Needs work» Needs review

Changing status for patch in #9

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community

#9! is rtbc :)

Dries’s picture

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.