Oops. :P

Two Bs and two Is in the WYSIWYG buttons.

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Assigned: Unassigned » Wim Leers
Status: Active » Postponed (maintainer needs more info)

This is strong & bold and emphasizes and italics. It's because we wanted to force users to see "b" for strong and "i" for italics, whereas Kevin had actually designed them to be separate.

Potential solutions:
- when only strong/em are allowed, show b/i
- when both strong/b and em/i are allowed, show s/b/em/i
- never show the b/i buttons

MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented

I think "never show the b/i buttons" will be fine as it encourages best use of s/em.

Should probably add a note of this somewhere though, README.txt perhaps.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

This is a good question, but the OP is a slightly different issue.

Spark's filtered HTML is set to:

<a> <em> <strong> <cite> <blockquote> <code> <ul> <ol> <li> <dl> <dt> <dd> <br> <p> <img> <pre>

So I don't understand why it thinks <b> and <i> buttons should be shown. They are not shown on the backend version of Aloha.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Postponed (maintainer needs more info) » Active

Moving back to active for #3, and spun off #1 and #2 to #1800670: How to deal with various combinations of <b>/<strong> & <i>/<em>.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Actually, superscript and subscript buttons are also showing, which implies that it's not "getting" that it should be using Filtered HTML. This sounds like a security problem.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

In latest Spark (as of right now, in git):
- at node/1/edit (back-end editing through Aloha): single b/i buttons
- at node/1 (front-end editing through Aloha): double b/i buttons

So, you're right, there has been a regression, and the allowed tags are no longer being picked up correctly.

I thought this issue was about the fact that you get double b/i buttons when you switch to "Full HTML" over at node/1/edit. I'll look into this later today.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Active » Fixed

It's a one-line fix.

But I can't push it:

$ git push origin 7.x-1.x
wimleers@git.drupal.org's password: 
fatal: remote error: Permission denied when accessing 'edit' as user 'wimleers'

Weird things are going on. I'll try to get this to work.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

At last.

http://drupalcode.org/project/edit.git/commit/e8b3867

Automatically closed -- issue fixed for 2 weeks with no activity.