This patch allows taxonomy_access to work with PostgreSQL while (hopefully!) preserving MySQL compatibility.

CommentFileSizeAuthor
#4 taxonomy_access_cvs-pgsql.patch7.38 KBZed Pobre
ta_pgsql.diff6.31 KBelonen

Comments

pyromanfo’s picture

pyromanfo commented

Is this against 4.5.0 or CVS? I'm just making sure because I thought I got rid of that "WHERE 1" stuff a while ago. That said, thanks for the patch. If it's against CVS I'll go ahead and commit it.

elonen’s picture

elonen commented

It's against 4.5. Aside from removing the "WHERE 1" conditions, the other change was just to substitute MySQL REPLACE statements with DELETE/INSERT pairs.

Zed Pobre’s picture

Zed Pobre commented

Just for your information, there are still WHERE 1 lines still in the CVS version. I just checked. I'm in the process of trying to repeat this patch by hand against the CVS tarball.

Zed Pobre’s picture

Zed Pobre commented
StatusFileSize
new taxonomy_access_cvs-pgsql.patch7.38 KB

I am attaching an updated patch against the CVS version of the module. This covers the module alone, not the SQL required to set up the tables.

pyromanfo’s picture

pyromanfo commented

Okay, I commited it to CVS, you also missed one of the "REPLACE INTOs" you added the "DELETE" but didn't change it to "INSERT". I fixed that. Though having to change the update functions to "INSERT" instead of "REPLACE" hopefully doesn't cause more bugs, but I'll just have to fix it another way if it comes to that.

Anonymous’s picture

(not verified) commented