Closed (fixed)
Project:
CiviCRM Starter Kit
Version:
7.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Sep 2012 at 15:04 UTC
Updated:
19 Nov 2013 at 20:07 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
franskuipers commentedI understand the .gz was needed to be able to upload these files.
For the downloaders: this are non-zipped tar files. Untar them with the commands:
tar -xf css.tar_.gz
tar -xf plugins.tar_.gz
Comment #2
skesslerPatch to test with removing IDS and replacing with correct Civi IDS folder.
Comment #3
skesslerPlease disregard the patch in 2 .
Comment #4
skesslerThis patch is for the Jquery Library
Comment #5
kreynen commentedI've updated the directory structure of JQuery in the .make...
http://drupalcode.org/project/cm_starterkit_moderate.git/blob/refs/heads...
I think this gets us a little closer to CiviCRM's default structure and will make the patch smaller. Please test.
Comment #6
kreynen commentedused the same process to generate this patch. After downloading the jquery-ui into development-bundle directory and leaving the demos, docs, and test directories, the patch is 'only' 1.2MB.
Comment #7
kreynen commentednope... this patch just includes comments about binary file changes. Won't apply with the .make
Comment #8
kreynen commentedtrying patch with --binary option... looks promising. Still 'only' 1.4MB
Comment #9
kreynen commentedBreaking the patch up into 2 patches. One adding the jquery/css and jquery/plugins run after jquery. The other adding the files needed in jquery-ui-1.8.16.
Comment #10
kreynen commentedWorked locally. Updated .make. Needs testing after packaging.
Comment #11
kreynen commentedPatches work, but files ending up in wrong directories based on where relative location of the patch in the .make. Updating paths.
Comment #12
kreynen commentedreplaced \ No newline at end of file with new lines in both patches
Comment #13
kreynen commentedSome of the files in 1787976-jquery-missing-files-3.patch are being created, but not complete. Not sure if this is because of how the patch was created or how it's being applied by drush during the .make processing. I'm breaking the problem files I've found into another patch to try to isolate the problem.
Comment #14
kreynen commentedThe issue w/ the missing files was caused by replacing the empty lines w/ +, but failing to adjust the number of lines in the @@ -0,0 +1,31 @@
Comment #15
kreynen commentedComment #17
kreynen commentedRemoving jstree from patch now that it has been added the whitelist #1886144: Add jsTree to the whitelist
Comment #18
kreynen commentedUpdated jquery.textresizer part of patch.
Comment #19
kreynen commentedstill getting an error in the textarearesizer.js part of this patch
Comment #20
kreynen commentedMoving textarearesizer into its own patch. Will eventually breakup all the plugins that can't be whitelisted into their own patches.
Comment #21
kreynen commentedcleaned up patch
Comment #22
kreynen commentedremoved textareasizer... other plugins still in single patch
Comment #23
kreynen commentedfixed the target directory
Comment #24
kreynen commentedComment #25
kreynen commentedmoved jquery.validate into its own patch
Comment #26
kreynen commentedThe larger patch that adds the files needed to be added to jquery-ui-1.9.0
Comment #27
kreynen commentedwrong patch attached last time
Comment #28
kreynen commentedremoved spaces that caused the patch to fail
Comment #29
kreynen commentedAdjusting the relative path. Even though this patch is to add files to jquery_ui, it needs to be applied with jquery. The jquery_ui library is downloaded to the development-bundle directory. Running this patch with libraries[jquery_ui] results in jquery/jquery-ui-1.9.0/development-bundle/css. We need jquery/jquery-ui-1.9.0/css
Comment #30
kreynen commentedfixed issue with menu.css truncating found in #1861304: Shortcut issue caused by CSS caching
Comment #31
kreynen commentedComment #32
kreynen commentedmoving jQuery.FormNavigate.js into its own patch #2018177: Javascript Errors on Contribution Widget Configuration
Comment #33
kreynen commentedUpdated path for some of the css/smoothness/images to jquery-ui-1.9.0 for dashboard.css
Comment #34
kreynen commented