The popup box div has a hard-coded style attribute of style="display:none; position: absolute; z-index:1".

I think you should remove the position and z-index and instead put them in the stylesheet. The reasons are:

1. They never change, even when the box is toggled by the Share link. The only thing that does change is the display attribute.

2. I don't want to use an absolute positioned box because sometimes the popup ends up partially "underneath" another div on my page due to a parent element having overflow:hidden. So to display it inline inside my links section I had to edit the source and remove these properties (I know I can use the block, but I prefer it inside the links section).

3. The popup is hit and miss on IE6. Sometimes text from other elements overlays the text in the popup.

Also I wanted to separate the positioning of the popup box from being inside the Share list item element. This is because when I displayed it inline, it would push the other node links out of place. So I modified the module to insert it just after the links. This required changing the id of the popup div to something like "share121_popup" so it can be targetted properly (similar to the code you use when dislaying as a block).

Another issue I noticed was that on firefox, switching tabs just didnt work properly for me after putting the box inline - the 'social web" tab remained visible all the time. I tracked it down to the opacity css property. jQuery has a supposed bugfix for Firefox where it never sets opacity to 1 - instead it uses 0.9999. Well that was causing this bug - using firebug to change opacity to 1.0 made things display correctly. Unfortunately that is jquery source so in the end I just disabled the animations on tab change, which I think is better in the end anyway.

Anyway, you can see an example on this page after the node text.

I can post my adjusted source if anyone wants it, but you will have to make a change to it as the placement of the inline box is relative to an element unique to my theme.

Comments

greenskin’s picture

Status: Active » Fixed

Thanks for your advice. The position and z-index have been moved to the css file as you have suggested. Any other advice you might have to enable the module to be better able to handle needs like your own are appreciated.

The updated module will be available with the next dev rollout.

greenskin’s picture

Status: Fixed » Closed (fixed)