Can't use "rewrite if empty" on fields using views_handler_field_numeric

If we want to fix something like that we need a test which prooves that there is something broken, sorry
but this will provide much better quality in the future.

Yes i mean a simpletest. Well obvious for you and now, but writing a test will ensure safety in the future.

I think the last patch failed because the hide_empty check was removed. If there is no empty text and hide_empty is not set, the field should be processed normally.

Here’s a patch with updated tests.

Fixed tests to match expected behavior.

#15: 178304-numerc_fields_test-15.patch queued for re-testing.

Here's the patch re-rolled for HEAD as the previous one no longer applies.

Sorry, let's try that again...

I think the current behaviour is definitely not right. There is no way to rewrite the results of an integer field if it's empty. It means the entire "No results behaviour" section is worthless. It doesn't matter what you specify there, it'll always be empty. I haven't tried any of the patches yet.

Here is a real world bug that the current views_handler_field_numeric causes w/ just Views and core.

Originally I thought the issue I was having filtering by File Usage had to do with the way Media was reporting usage, but @Dave Reid pointed out this happens with any files. The only relation to Media was that the Media File Selector Widget gives you the UI to find and use files from the site that aren't being used up to that point. If you only use the Image widget, all uploaded images are used by the node... unless the node isn't saved. Then you can get images into your file library with 0 usage which can't be found using Views to filter.

The bug is easy to reproduce:

• enable Image, Views and Views UI on a fresh install
• add an image field to a content type (Field Type: Image/Widget Image)
• start adding a node and add an image to that node
• save the node
• start adding a node and add an image to that node
• DO NOT save the node

If you look at admin/content/file, there should now be 1 used and 1 un-used file. Now create a File view and filter by usage = 1. That works, but changing usage to = 0 or < 1 does not. That is because the query will look something like...

SELECT file_managed.filename AS file_managed_filename, file_managed.fid AS fid, file_managed.uri AS file_managed_uri, file_usage.count AS file_usage_count
FROM 
{file_managed} file_managed
LEFT JOIN {file_usage} file_usage ON file_managed.fid = file_usage.fid
WHERE (( (file_usage.count = '0') ))

Looking at the file_usage table, there are only records for used files. Without a row in file_usage for the unused files, file_usage.count needs to be IS NULL for the query to return the unused files.

I'm not sure if there is any easy way to deal with null values in a numeric handler, but I found this attempt to address the issue at the file_entity level.

#2052461: Provide "file in use" views filter

I tried to apply the patch from 8/3/2013 to the current 7.x-3.x branch, but it failed. Looking at why now.

we've found a work around for this in cmdrupal

The latest 5 year old patch in #27 to views_handler_field_numeric.inc and views.info does not apply to the latest views 7.x-3.x-dev.

Checking patch handlers/views_handler_field_numeric.inc...
error: while searching for:
      }
    }

    // Check to see if hiding should happen before adding prefix and suffix.
    if ($this->options['hide_empty'] && empty($value) && ($value !== 0 || $this->options['empty_zero'])) {
      return '';
    }

error: patch failed: handlers/views_handler_field_numeric.inc:120
error: handlers/views_handler_field_numeric.inc: patch does not apply

Checking patch views.info...
Hunk #1 succeeded at 277 (offset 12 lines).

Patch rerolled.

Just the tests.

Adding folks who worked on an identical issue: #1789294: Zero values with decimals not being treated as zero in views_handler_field_numeric

So the tests-only patch should fail, but it passes. Could someone please extend the test to make it fail, so we can confirm it's fixing this bug? Thanks.

Removing this from the queue for the next release because the tests don't fail as expected.

I tried this patch#35, it applied cleanly, but did not solve my problem... the text entered in the no result behavior still does not display.

My number is a decimal field, formatted with 2 precision, using comma and a "space $" suffix...
so the "zero" value is displayed like this: 0,00 $

I have also added this patch to try : https://www.drupal.org/project/views/issues/1239522
But it also did not solve the issue...

I have managed a workaround to get it working by using views conditional, and setting the value less than 1 since in my use case the value will never be 0.99 or below... trying equals or not equals (0) (0,00) (0,00 $), or even greater than 0 did not work with conditional views either... only the less than 1 actually worked.