This patch extends the basic functionality of "No payment" payment method so that it can be used multiple times on the same payment form.
For example, let's say you have two different payment options that do not require payment, e.g. "Scholarship" and "Waiver request".
Rather than having to implement two entirely new payment method to do exactly the same thing as this module, you can now simply rename the label from "No payment" to the appropriate method.
Additionally, you can provide explanatory text for each different "no payment" method.

This is a good solution for someone who wants various free payment methods but doesn't want to implement a bulky framework like http://drupal.org/project/payment

CommentFileSizeAuthor
#2 Editing action _Enable payment method_ No payment_ | The Energy Co-op.png27.01 KBaaronbauman
#2 Review order | The Energy Co-op.png22.21 KBaaronbauman
#1 relabel_payment_options-commerce_no_payment-1781472.patch2.24 KBaaronbauman

Comments

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Needs review
StatusFileSize
new relabel_payment_options-commerce_no_payment-1781472.patch2.24 KB

Here's the patch

aaronbauman’s picture

aaronbauman
he/him
commented
StatusFileSize
new Review order | The Energy Co-op.png22.21 KB
new Editing action _Enable payment method_ No payment_ | The Energy Co-op.png27.01 KB

Here's a screenshot of the rule configuration:

And here's a screenshot of the payment form in action:

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs review » Needs work

I like this idea. There is another patch over at #1759500: Add settings for payment form text and to optionally enforce order balance of 0 but this patch is more focused and in my opinion closer to being committable.

Two things right off the bat:

1. Remove any trailing whitespace.
2. The patch should be against 7.x-1.x-dev. You'll need to use git to download the dev version, there is no download available from the project page.

+++ commerce_no_payment/commerce_no_payment.module	(working copy)
@@ -33,6 +72,19 @@
+    $form['commerce_cheque_description'] = array(

Why is commerce_cheque_description used here?

+++ commerce_no_payment/commerce_no_payment.module	(working copy)
@@ -33,6 +72,19 @@
+  // Need to create a dummy value to solve http://drupal.org/node/1230666
+  // Probably an issue in the main commerce module
+  $form['dummy'] = array(
+    '#type' => 'hidden',
+    '#value' => 'dummy'
+  );

Is this dummy value still needed? The 'Merge in default values' bit is not in the dev version any more and the issue linked has been fixed.

Also, as in the patch at #1759500: Add settings for payment form text and to optionally enforce order balance of 0 the label and description values should be run through filter_xss().

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Closed (won't fix)

Won't-fixing this issue, because Commerce No Payment is now abandoned in favor of Payment's Basic payment method. See #1932462: Migrate Commerce No Payment to Payment for work on migrating existing sites. Read Configuring "no payment required" payment methods to see how to replicate Commerce No Payment's behavior using Payment yourself.