original bugreport: #1764912: Fix regressions and further improve tableheader.js

The original table header bleeds through the sticky table header:
table header bleed-through

I think I traced it back to the following code:

http://drupalcode.org/project/drupal.git/blob/refs/heads/8.x:/core/theme...

table th a {
    display: block;
    position: relative;
}

The position: relative seems to be the culprit. A quick fix would be to add a z-index, but I think that would open a whole new can of worms related to other elements using z-indices (overlay, toolbar, other stuff) so I think a more elegant solution would be required. I don't have it though :).

Only tested in Seven, might also be present in other themes?

CommentFileSizeAuthor
old_header_visible_under_sticky_0.png65 KBKiphaas7
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Kiphaas7’s picture

Kiphaas7 CreditAttribution: Kiphaas7 commented
Component: javascript » Seven theme

Yea....

Kiphaas7’s picture

Kiphaas7 CreditAttribution: Kiphaas7 commented

Quoting myself for possible patch ideas:

Aha!

table th a {
    display: block;
    position: relative;
}

Seems to be the culprit for the bleed-through. It only happens with links, and the position: relative; is responsible

Removing it from the original table (not the sticky table) seems to fix it.

Kiphaas7’s picture

Kiphaas7 CreditAttribution: Kiphaas7 commented

Related, with a possible fix already proposed for committing:
http://drupal.org/node/1608878#comment-6496942

But I'd still like to see us working it out without resorting to z-indexes.

justinchev’s picture

justinchev CreditAttribution: justinchev commented
Issue summary: View changes

Is this still an issue? I'm unable to reproduce this problem using the D8 beta1 release. If it is still an issue please provide details to reproduce.

I tested it in Chrome 37.0.2062.94, Safari 7.1 & Firefox 28

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Active » Postponed (maintainer needs more info)

Neither can I

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pameeela’s picture

pameeela CreditAttribution: pameeela commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Thanks everyone for contributing to this issue.

As part of the Bug smash initiative, we are triaging issues that are marked 'Postponed (maintainer needs more info)'. Based on the earlier comments that contributors could not reproduce, and my inability to reproduce the issue now, we believe this issue has been fixed as part of another issue, so I am marking it 'Closed (outdated)'.

If anyone believes this issue should not be closed, please provide specific steps to reproduce when reopening it.

pameeela’s picture

pameeela CreditAttribution: pameeela commented
Issue tags: +Bug Smash Initiative

Forgot to tag.