Instead of calling flag_get_flags() with the $reset parameter TRUE, we should call:

    drupal_static_reset('flag_get_flags');

The $reset parameter can also be removed.

CommentFileSizeAuthor
#4 flag-remove-flags-reset-1780520-3.patch2.92 KBkid_icarus
#3 1780520.3.removeFlagsReset.patch3.15 KBsocketwench
#1 1780520.1.removeFlagsReset.patch3.1 KBsocketwench

Comments

socketwench’s picture

socketwench commented
Status: Active » Needs review
StatusFileSize
new 1780520.1.removeFlagsReset.patch3.1 KB

Status: Needs review » Needs work

The last submitted patch, 1780520.1.removeFlagsReset.patch, failed testing.

socketwench’s picture

socketwench commented
Status: Needs work » Needs review
StatusFileSize
new 1780520.3.removeFlagsReset.patch3.15 KB

Rebase.

kid_icarus’s picture

kid_icarus commented
StatusFileSize
new flag-remove-flags-reset-1780520-3.patch2.92 KB

Not sure what happened here, but I manually re-rolled :)

Applies cleanly at 2dbe641.

kid_icarus’s picture

kid_icarus commented
Status: Needs work » Needs review

Whoops, I should have refreshed before posting...

I also should have noted that I was on master and not on 7.x-3.x

Carry on xD

Status: Needs review » Needs work

The last submitted patch, flag-remove-flags-reset-1780520-3.patch, failed testing.

joachim’s picture

joachim commented
Status: Needs review » Fixed

Thanks! Committed.

git commit -m "Issue #1780520 by socketwench: Removed flag_get_flags() $reset parameter, changed reset calls to use drupal_static_reset()." --author="rashfeather "

rashfeather? ;)

socketwench’s picture

socketwench commented

There's a bit of a story behind "rashfeather". Technically, it's "R. AshFeather", but many systems didn't take special characters, so the sillier reading stuck. After all, feathers are itchy! ^_^

I temporarily changed my D.O username to it when I was tossing out some CVs to Acquia and the like, but when that didn't pan out I reorganized my usernames to keep "rashfeather" for my private/locked down accounts. "Socketwench" is the public persona. Unfortunately, the former username stuck on git. *shrugs*

joachim’s picture

joachim commented

You can change your git attribution to whatever you like -- it's set in your d.org user profile.

Automatically closed -- issue fixed for 2 weeks with no activity.