While making patch for #1654990: Coupons pane 'locked' on checkout page coder complained about some (mostly minor) issues.
I intend to provide a patch solving this.

CommentFileSizeAuthor
#1 commerce_coupon-coder_issues-1775386-2.patch3.34 KBfirfin

Comments

firfin’s picture

firfin commented
Title: clean up some issues (from coder) » Make coupon pass Coder Review
Status: Active » Needs review
StatusFileSize
new commerce_coupon-coder_issues-1775386-2.patch3.34 KB

Besides the issues solved with coder I also corrected a small typo (informations).
One of the coder issues was already marked as a @todo namely the underscore needed for global variables.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Fixed

Committing this and marking #1530528: Drupal coding standards as duplicate.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.