I started only for fixing t('!action by @user.' bug, but after a few minutes I decided to make a full review, what ended with a lot of strings that need changes.

CommentFileSizeAuthor
#10 workbench_moderation_1768584+Translatable+string+review.patch23.7 KBhass
#2 Workbench_Moderation_Translatable+string+review_2012090102.patch25.16 KBhass
Workbench_Moderation_Translatable+string+review_20120901.patch25.16 KBhass

Comments

Status: Needs review » Needs work

The last submitted patch, Workbench_Moderation_Translatable+string+review_20120901.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new Workbench_Moderation_Translatable+string+review_2012090102.patch25.16 KB

New try... too many brackets... :-)

hass’s picture

hass commented

Still applies.

hass’s picture

hass commented
Issue tags: +Workbench Sprint
kbentham’s picture

kbentham commented
Status: Needs review » Reviewed & tested by the community

This patch looks good.

stevector’s picture

stevector
he/him
commented

There are a bunch of in-progress patches that edit the exported view like #1781744: Draft and Needs review pages are broken

I'd rather patch that View only once so we're not stuck rerolling too many patches. hass, what do you think of committing this patch minus the changes to the View?

hass’s picture

hass commented

Last weekend I have applied http://drupal.org/node/1781744#comment-6932118 first and than this patch without any hunks. Other commit orders have not tested by me. If it's only the view, we can re-role.

hass’s picture

hass commented

Maybe we can commit in this order:

  1. http://drupal.org/node/1781744#comment-6932118
  2. #1548050: Change t('Moderate') to t('Set moderation state')
  3. http://drupal.org/node/1768584#comment-6424638 (#2)
  4. and than do a export of the view and commit the diffs.
hass’s picture

hass commented 
+++ b/workbench_moderation.node.inc
@@ -182,7 +182,7 @@
-      $row['data']['moderation'] .= '<div class="moderation-actions">' . t('Moderate') . ': ' . drupal_render($moderate_form) . '</div>';
+      $row['data']['moderation'] .= '<div class="moderation-actions">' . t('Set moderation state: !moderation-actions-form', array('!moderation-actions-form' => drupal_render($moderate_form))) . '</div>';

In #1548050: Change t('Moderate') to t('Set moderation state') has a conflict with this patch. It's a better fix in #1548050: Change t('Moderate') to t('Set moderation state') than here. Many months between both patches... the one hunk can just be ignored.

hass’s picture

hass commented
StatusFileSize
new workbench_moderation_1768584+Translatable+string+review.patch23.7 KB

Re-roled patch because of hunks.

stevector’s picture

stevector
he/him
commented
Status: Reviewed & tested by the community » Fixed

hass++

http://drupal.org/commitlog/commit/18554/c68e678f81d14cee9d8568a872c3212...

hass’s picture

hass commented

Are these strings used in 2.x and are we running in regressions here?

Automatically closed -- issue fixed for 2 weeks with no activity.