The default front page is shown instead of the chosen path. [#1761546]

create a taxonomy space
go to "Features" tab
set the drop down menu "Default front page" to "Other..."
set internal drupal path eg. "node/1234" at "A relative path"
go to the front page of the taxonomy space

Result: Showing the default front page of the website instead of the chosen node.

I found a TODO in spaces_controller_variable.inc in the function init_overrides() .

    // If we have overridden 'site_frontpage', we need to do some extra
    // work to reinit the drupal path.
    // TODO: Is purl_language_strip still needed?
    //if ($this->get('site_frontpage') !== $this->get('site_frontpage', 'original') && function_exists('purl_language_strip')) {
    //  $_GET['q'] = purl_language_strip($_REQUEST['q']);
    //  drupal_path_initialize();
    //}

Comment	File	Size	Author
#6	1761546-6-spaces-default_front_page.patch	1.46 KB	pfrenssen
#4	spaces-1761546-4-correct_frontpage.patch	1.3 KB	sandervd
#1	1761546-1-spaces-set_correct_frontpage.patch	1.18 KB	iSoLate

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

iSoLate CreditAttribution: iSoLate commented 30 August 2012 at 08:22

Status:

Active

» Needs review

File	Size
1761546-1-spaces-set_correct_frontpage.patch	1.18 KB

I created an initial patch. This covers only spaces_taxonomy.

Comment #3

pfrenssen

Sofia

CreditAttribution: pfrenssen commented 2 September 2012 at 21:30

Status:

Needs review

» Needs work

This only works for paths that do not end in a slash. To support paths ending in a slash as well:

-    if ($uri == $_SERVER['REQUEST_URI']) {
+    if ($uri == rtrim($_SERVER['REQUEST_URI'], '/')) {

Comment #4

sandervd CreditAttribution: sandervd commented 4 December 2012 at 17:20

Status:

Needs work

» Needs review

File	Size
spaces-1761546-4-correct_frontpage.patch	1.3 KB

A bit more generic approach: Call drupal_path_initialize when the variables controller is loaded. Sets the frontpage correctly for all spaces types.

Comment #5

pfrenssen

Sofia

CreditAttribution: pfrenssen commented 6 December 2012 at 21:08

Status:

Needs review

» Needs work

Patch from #4 looks promising but I'm encountering some problems:

When the front page is still set to the default value ('node') this does not work. $this->get('site_frontpage', 'original') returns NULL until it is manually resaved in the default features variable settings at the path /features. There are instructions at /admin/config/system/site-information but this should really work out of the box without manual intervention.

"The front page is controlled by the spaces module and can be set here."
When visiting the front page of a space I get a notice:

Notice: Undefined index: q in spaces_controller_variable->init_overrides() (line 35 of sites/all/modules/patched/spaces/plugins/spaces_controller_variable.inc).