Convert ./core/modules/search/search-results.tpl.php to twig.

Twig_Error_Syntax: Unexpected tag name "trans" (expecting closing tag for the "if" tag defined near line 20) in "core/themes/stark/templates/search/search-results.twig" at line 21 in Twig_Parser->subparse() (line 165 of /var/www/drupalway/core/vendor/twig/twig/lib/Twig/Parser.php).

Fixed strings translation

looks good!
thanks

commited #5
thanks!

git apply *.patch
error: core/themes/stark/templates/search/search-results.twig: No such file or directory

not applying into latest 8.x
need reroll!

it looks like #5 applying good to old merge_chx_sandbox branch that already removed by @jenlampton
I`ll look at my local copy of old repo for do not lost this work

fixed this from recovery

I made one change to this file. The class attributes should be separated from the others when you think theme devs might want to add a class. <li class="{{ attributes.class }}" {{ attributes }}>

Otherwise, this template looks great! I made this change and committed the template to the front-end branch. :)

The template was committed to the front-end branch but mis-spelled.

Before:
search-result.twig

Now:
search-results.twig

I know it's preferred we commit these to the repo directly without submitting a patch, but I don't think I have commit rights, so am posting this as a patch.

Changing status to patch. I'm kinda new to this, so please let me know if I am breaking protocol.

nope
this needs review

This is issue is a bit confusing. There is no port of ./core/modules/search/search-results.tpl.php to twig in the front-end branch into a twig template. The patch attached to #12 is converting a file that does not in fact pertain to this issue (though it is close in name, -result as opposed to -results). I am going to mark this back as needs work since there does not appear to be patch here for the ./core/modules/search/search-results.tpl.php file and it hasn't yet been converted.

I commited the working version from the code-sprint.

This is fixed now in front-end.

Thanks!

There was one trivial @TODO in this file... fixed... #7553295