Customized mail subject

If you search for !site :: new comment for your post. in the localizer.module you can translate it.
Or you have to search for the same sentence in the comment_notify,module to change it the hardcoded way if you are using english drupal

You can also use locale to translate from "english" to "my english" and then modify it.

I agree, though, it would be nice to be able to set the subject in some configurable way.

If it happens it will be for 6.x.

can you do this now with the 'string overrides' module without adding into this module (for time being)?

I believe so, yes.

honestly, and i don't mean this to be darkly comical, i find the string overrides module most useful for getting rid of nerdy drupal language (it's all over the place, legacy text throughout drupal instead of plain language) AND for correcting output from modules developed by non-native english speakers who are trying to put out a first release in english only (things like "sing in here" instead of sign in etc...) - it's a very powerful little tool and keeps people out of core module files or other core drupal stuff...in my mind a perfect candidate for a 'core' utility ;)

It is in core. It's called "locale".

String Overrides was developed to be a "light weight" solution beyond locale, but subsequent performance tests show that locale and string overrides are about the same speed.

@greggles - didn't realize that...i know that people have used locale for the same purpose for a long time, the SO module just seemed to be a more intuitive way to handle minor edits and modifications for users who don't want to mess around with language related changes - and coupled with tools like form editors, it's quite useful...

Mee too,
Its a necessary feature.

Offtopic:
If you are using flat comments, users can not understand the “all comments” or “replies to my comment option”

Offtopic:

Quite - better to open a new issue.

If you are using flat comments, users can not understand the “all comments” or “replies to my comment option”

Administer > Site configuration > Comment notify. Disable the "replies to my comment" option. Then users will only see a checkbox and will no longer be confused.

they can still seen it in their personal menu (My account).

@guitarrasybajos - #417582: if only one subscription mode is enabled, users should only see one option in their edit page

Just wanted to steer this back to the original issue - the need for a customizable Subject field...

Attached patch is against 6.x-1.x-dev, allows configurable subject for author and commenter emails and keeps defaults as they were. Same substitution variables are available as in the message bodies.

Patch worked for me! +1

"Works for me" is not a "review". Patches need a review prior to RTBC status.

My initial review makes me think that node_notify_default_mailsubject is not a great variable name (it follows pattern for other variables for this module, but it isn't properly namespaced with comment_notify at the beginning).

We also need to delete the variable comment_notify_default_mailsubject on uninstall.

And, ideally this should be done for 7.x first and 6.x only after that.

Good points all. I get a little overzealous with my clicking-finger.

My initial review makes me think that node_notify_default_mailsubject is not a great variable name (it follows pattern for other variables for this module, but it isn't properly namespaced with comment_notify at the beginning).

Modified patch attached using comment_notify_author_mailsubject

We also need to delete the variable comment_notify_default_mailsubject on uninstall.

Not required as there is already a DELETE FROM variable WHERE name LIKE 'comment_notify_%' in hook_uninstall()

And, ideally this should be done for 7.x first and 6.x only after that.

Sorry, don't have a 7.x platform to test on.

Seconding this request.

Here's a fairly simple workaround that worked for me.

See: http://api.drupal.org/api/drupal/developer--hooks--core.php/function/hoo...
and: http://api.drupal.org/api/drupal/includes--mail.inc/function/drupal_mail/6
noting "The final e-mail id for e-mail altering will be {$module}_{$key}."

Sample code:

function mymodule_mail_alter(&$message){
	if($message['id'] == 'comment_notify_comment_notify_mail'){ // comment_notify.module, line 435
		$message['subject'] = "A new comment was posted after your comment."
	}
}

Old thread, but still interested in seeing this in the module.

Thanks.

This is still waiting on a patch for 7.x.

Attached is a patch against 7.x-1.2 which adds fields to the admin form for editing email subject lines. This patch simply exposes the existing variables for email subjects from inside the admin form. Please review.

Stille no solution for D7

Pafla

Here is a tweak of the patch in #24 -- sloppy diff on my part. Let's see if this passes testing.

Here’s a patch to get this into the D8 branch.

FYI I've pulled these changes into a patch on #2618182: Support all entity types as commentable, not only nodes.

#2618182: Support all entity types as commentable, not only nodes has been fixed we can close this one as well.

Thanks!