Problem/Motivation

In D8 everything can be commentable, but the node entity type is still very much hardcoded in comment_notify.

Proposed resolution

Generalize over entity types. The comment_notify table in its current form would need an additional "entity_type" column, and all occurrences of "node" and "nid" should be changed to "entity" (perhaps?) and "entity_id".

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#64 comment_notify-2618182-63-64-interdiff.txt1.19 KBgnuget
#64 comment_notify-2618182-64.patch68.5 KBgnuget
#63 comment_notify-2618182-62-63-interdiff.txt1.66 KBgnuget
#63 comment_notify-2618182-63.patch68.28 KBgnuget
#62 comment_notify-2618182-62.patch68.17 KBSilvan Wakker
#62 comment_notify-2618182-59-62-interdiff.txt10.16 KBSilvan Wakker
#59 comment_notify-2618182-59.patch67.5 KBgnuget
#59 comment_notify-2618182-58-59-interdiff.txt5.08 KBgnuget
#58 comment_notify-2618182-58.patch62.69 KBgnuget
#58 comment_notify-2618182-56-58-interdiff.txt3.62 KBgnuget
#56 comment_notify-2618182-56.patch62.85 KBgnuget
#56 comment_notify-2618182-55-56-interdiff.txt8.07 KBgnuget
#55 comment_notify-2618182-55.patch57.74 KBgnuget
#55 comment_notify-2618182-53-55-interdiff.txt1.96 KBgnuget
#53 comment_notify-2618182-53.patch57.37 KBgnuget
#53 comment_notify-2618182-rebase-51-53-interdiff.txt15.7 KBgnuget
#51 comment_notify-2618182-rebase-46-51.patch42.79 KBgnuget
#46 comment_notify-2618182-46.patch44.74 KBSilvan Wakker
#39 comment_notify-2618182-39.interdiff.patch884 bytesashrafabed
#39 comment_notify-2618182-39.patch45.53 KBashrafabed
#38 comment_notify-n2618182-38.interdiff.txt1.53 KBDamienMcKenna
#38 comment_notify-n2618182-38.patch45.1 KBDamienMcKenna
#37 comment_notify-n2618182-37.patch44.27 KBDamienMcKenna
#35 comment_notify-n2618182-35.interdiff.txt2.74 KBDamienMcKenna
#35 comment_notify-n2618182-35.patch44.27 KBDamienMcKenna
#34 comment_notify-n2618182-34.interdiff.txt621 bytesDamienMcKenna
#34 comment_notify-n2618182-34.patch43.04 KBDamienMcKenna
#33 comment_notify-n2618182-33.interdiff.txt906 bytesDamienMcKenna
#33 comment_notify-n2618182-33.patch43.02 KBDamienMcKenna
#29 comment_notify-n2618182-29.patch42.76 KBDamienMcKenna
#29 comment_notify-n2618182-29.interdiff.txt799 bytesDamienMcKenna
#26 comment_notify-n2618182-26.interdiff.txt3.03 KBDamienMcKenna
#26 comment_notify-n2618182-26.patch42.74 KBDamienMcKenna
#24 comment_notify-n2618182-24.patch42.44 KBDamienMcKenna
#24 comment_notify-n2618182-24.interdiff.txt2.67 KBDamienMcKenna
#22 comment_notify-n2618182-22.patch41.6 KBDamienMcKenna
#22 comment_notify-n2618182-22.interdiff.txt806 bytesDamienMcKenna
#20 comment_notify-n2618182-20.interdiff.txt1.37 KBDamienMcKenna
#20 comment_notify-n2618182-20.patch40.82 KBDamienMcKenna
#17 comment_notify-n2618182-17.patch40.86 KBDamienMcKenna
#17 comment_notify-n2618182-17.interdiff.txt14.5 KBDamienMcKenna
#14 comment_notify-n2618182-14.interdiff.txt8.3 KBDamienMcKenna
#14 comment_notify-n2618182-14.patch32.21 KBDamienMcKenna
#10 comment_notify-n2618182-10.patch32.09 KBDamienMcKenna
#10 comment_notify-n2618182-10.interdiff.txt6.34 KBDamienMcKenna
#6 comment_notify-support_all_entity_types-2618182-6.patch30.17 KBashrafabed
#5 comment_notify-support_all_entity_types-2618182-5.patch28.29 KBashrafabed
#4 comment_notify-support_all_entity_types-2618182-4.patch31.57 KBashrafabed
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Arla created an issue. See original summary.

ashrafabed’s picture

Assigned: Unassigned » ashrafabed

I am working on this issue as part of a class offered by http://debugacademy.com

ashrafabed’s picture

I have the updated module functionality to work with all entity types. Will have a patch submitted next week.

ashrafabed’s picture

I am attaching a patch for this issue.

Pieces missing from the patch before it can be tested/reviewed:
1- Schema change(s), update hooks
2- Creating a separate e-mail template for non-node notifications (due to token support for [node], but no token support for [entity])
3- Updating automated tests

Items 1 & 2 will be completed by a class at http://debugacademy.com within about 24 hours.

ashrafabed’s picture

I had attached the wrong patch. Updating file attachment.

ashrafabed’s picture

Status: Active » Needs review
FileSize
30.17 KB

The full patch is attached (but automated tests have not been updated). Could this can be merged in as-is? Then automated tests can come next, as well as potentially another e-mail template as part of a separate issue

peezy’s picture

Thanks for your work on this, @ashrafabed. I successfully applied the patch to the latest dev, but I'm getting this PHP error every time I comment on a user:

Error: Call to a member function id() on null in _comment_notify_mailalert() (line 357 of /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/modules/contrib/comment_notify/comment_notify.module) #0 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/modules/contrib/comment_notify/comment_notify.module(179): _comment_notify_mailalert(Object(Drupal\comment\Entity\Comment)) #1 [internal function]: comment_notify_comment_insert(Object(Drupal\comment\Entity\Comment)) #2 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Extension/ModuleHandler.php(402): call_user_func_array('comment_notify_...', Array) #3 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Entity/EntityStorageBase.php(167): Drupal\Core\Extension\ModuleHandler->invokeAll('comment_insert', Array) #4 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(441): Drupal\Core\Entity\EntityStorageBase->invokeHook('insert', Object(Drupal\comment\Entity\Comment)) #5 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Entity/EntityStorageBase.php(470): Drupal\Core\Entity\ContentEntityStorageBase->invokeHook('insert', Object(Drupal\comment\Entity\Comment)) #6 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(326): Drupal\Core\Entity\EntityStorageBase->doPostSave(Object(Drupal\comment\Entity\Comment), false) #7 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Entity/EntityStorageBase.php(395): Drupal\Core\Entity\ContentEntityStorageBase->doPostSave(Object(Drupal\comment\Entity\Comment), false) #8 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php(768): Drupal\Core\Entity\EntityStorageBase->save(Object(Drupal\comment\Entity\Comment)) #9 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Entity/Entity.php(364): Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object(Drupal\comment\Entity\Comment)) #10 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/modules/comment/src/CommentForm.php(364): Drupal\Core\Entity\Entity->save() #11 [internal function]: Drupal\comment\CommentForm->save(Array, Object(Drupal\Core\Form\FormState)) #12 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Form/FormSubmitter.php(111): call_user_func_array(Array, Array) #13 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Form/FormSubmitter.php(51): Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object(Drupal\Core\Form\FormState)) #14 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Form/FormBuilder.php(585): Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object(Drupal\Core\Form\FormState)) #15 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Form/FormBuilder.php(314): Drupal\Core\Form\FormBuilder->processForm('comment_profile...', Array, Object(Drupal\Core\Form\FormState)) #16 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Entity/EntityFormBuilder.php(48): Drupal\Core\Form\FormBuilder->buildForm('comment_profile...', Object(Drupal\Core\Form\FormState)) #17 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/modules/comment/src/Controller/CommentController.php(249): Drupal\Core\Entity\EntityFormBuilder->getForm(Object(Drupal\comment\Entity\Comment)) #18 [internal function]: Drupal\comment\Controller\CommentController->getReplyForm(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\user\Entity\User), 'field_add_a_new...', NULL) #19 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array) #20 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/Render/Renderer.php(574): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #21 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) #22 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) #23 [internal function]: Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #24 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/vendor/symfony/http-kernel/HttpKernel.php(144): call_user_func_array(Object(Closure), Array) #25 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/vendor/symfony/http-kernel/HttpKernel.php(64): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #26 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #27 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #28 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/modules/page_cache/src/StackMiddleware/PageCache.php(99): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #29 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/modules/page_cache/src/StackMiddleware/PageCache.php(78): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true) #30 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #31 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(50): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #32 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #33 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/core/lib/Drupal/Core/DrupalKernel.php(656): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #34 /srv/bindings/3c1a4731aa2648fd9d1a1a4417a95e37/code/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #35 {main}.

Also, I am unable to create users as described here: https://www.drupal.org/node/2684617

Is there a chance that the patch needs to get re-rolled against the latest dev? Also, I'm using PHP 7 and D8.3.7 in case that makes a difference.

ashrafabed’s picture

@peezy I'll take a look at that shortly, thanks for letting me know

DamienMcKenna’s picture

Assigned: ashrafabed » DamienMcKenna
Status: Needs review » Needs work

This seems great but there are a few things that need work:

  • The first update script should use db_change_field() to change the field.
  • The notification emails need some way of handling different entities. Right now they're hardcoded to work off nodes and use [node:title].
  • The main settings page throws a number of errors.
  • The error listed above by JP.
DamienMcKenna’s picture

Some fixes.

  • Replaced the database schema changeField() call with a simple db_change_field() call in update 8001.
  • Fixed the error JP reported in _comment_notify_mailalert().
  • Fixed errors in the settings page.
DamienMcKenna’s picture

Status: Needs review » Needs work

Even with all this the emails don't seem to actually get generated.. Still working on it.

DamienMcKenna’s picture

I think the custom table needs to be expanded to track the entity type and we need separate notification messages for each entity type.

DamienMcKenna’s picture

No, the custom table doesn't need to track the entity type but there definitely needs to be separate notification messages for each entity type.

DamienMcKenna’s picture

I had forgotten to handle the previous interdiff properly after the last patch, so this interdiff is against #6.

This appears to be working for both nodes, users, etc.

Still need to work on notification messages.

DamienMcKenna’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 14: comment_notify-n2618182-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

DamienMcKenna’s picture

This now allows editing different messages for each entity type that is supported.

DamienMcKenna’s picture

I wonder if it would be better to move some of these settings to the comment field settings?

Status: Needs review » Needs work

The last submitted patch, 17: comment_notify-n2618182-17.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

DamienMcKenna’s picture

Mixed up the schema.yml config. This should work.

Status: Needs review » Needs work

The last submitted patch, 20: comment_notify-n2618182-20.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

DamienMcKenna’s picture

Fixed the constant being renamed.

Status: Needs review » Needs work

The last submitted patch, 22: comment_notify-n2618182-22.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

DamienMcKenna’s picture

A small UX improvement for the settings page - it automatically hides the email fields for an entity type if none of the comment types for that entity type are hidden.

Status: Needs review » Needs work

The last submitted patch, 24: comment_notify-n2618182-24.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

DamienMcKenna’s picture

This should fix errors.

DamienMcKenna’s picture

Tests are green. Sweet. Now to see if someone would be so kind as to test it out.

DamienMcKenna’s picture

BTW there's a @todo item in the update script, the bundle configuration needs to be updated to match the new structure.

DamienMcKenna’s picture

Forgot to include the 'comment-subscribed' token type for the 'watcher' email.

DamienMcKenna’s picture

Status: Needs review » Needs work

The patch results in the following error when a user registers a new account:

Error: Call to undefined method Drupal\user\Entity\User::getOwner() in _comment_notify_mailalert() (line 354 of comment_notify.module).

DamienMcKenna’s picture

Status: Needs work » Needs review

Never mind, some custom code was tripping it up.

DamienMcKenna’s picture

That said, there was a problem sending notifications on the user entity if the comment was generated during the user registration process as the $entity didn't have a getOwner() method. This adds an extra check to see if the $entity is a user object, and if it is it just uses that entity directly as the author.

DamienMcKenna’s picture

Forgot to use the full class namespace on the instanceOf call.

DamienMcKenna’s picture

This includes changes from #173979: Customized mail subject to make the subject lines editable, otherwise this error gets thrown when messages are sent: "undefined index: subject in _comment_notify_mailalert()"

toamit’s picture

Just tested this patch on a custom entity and it works.
Thanks for sharing the patch.

DamienMcKenna’s picture

DamienMcKenna’s picture

ashrafabed’s picture

I found two minor issues with the patch.

1. in src/Form/CommentNotifySettings.php, the visibility of the 'body' fields is determined using Drupal's #states, but the 'subject' field was not. So the subject field was always displaying, whether or not it should. That was fixed.

2. The subject label on the comment notify form does not say what entity type it is for. When multiple entity types are commentable, you couldn't tell what entity type you were creating the email notification template for. I added the entity type to the label: '#title' => $this->t('Default mail subject for sending out :entity_type notifications to commenters', [':entity_type' => $entity_type]),

Updated patch is attached.

Status: Needs review » Needs work

The last submitted patch, 39: comment_notify-2618182-39.interdiff.patch, failed testing. View results

ashrafabed’s picture

The second attachment in my previous comment should not have ended in .patch, so the tests that should have run actually did pass.

ashrafabed’s picture

Status: Needs work » Needs review
toamit’s picture

Tested #39 patch against comment_notify-8.x-1.0-beta2 . I had to run update.php for this patch to work correctly

The following things were tested and worked
- Able to create comment notification option for non-node custom entity
- Email notification are sent for authenticated subscribed users with All setting

Problem
- Email notification are not sent when Reply to my comments is subscribed.
There is another issue about this though at https://www.drupal.org/project/comment_notify/issues/2879914

ashrafabed’s picture

Thank you for the review @toamit. It is correct that running update.php (or drush updb) is necessary to apply the patch.

The problem you mentioned is in fact unrelated to this issue, and fits in the other issue you linked to.

I'm using this patch on production today, it is working very well for our comment-heavy website. If you've reviewed the work and feel comfortable switching from needs review to Reviewed & tested, feel free to - I'm looking forward to this (hopefully) getting merged into the project.

toamit’s picture

Status: Needs review » Reviewed & tested by the community

Based on functional test, updating the status to RTBC. No code review was performed by me, if needed please revert back the status and assign it to a code reviewer.

Silvan Wakker’s picture

The latest patch (from #39) failed applying against the latest version of dev (SHA 01751b118ce3765fe3af07a36ca8c6f6687c6534). I've tried to manually apply all the rejects and the module seems to be working fine but I can't figure one thing out. In the file comment_notify/src/Form/CommentNotifySettings.php at line 80 (after applying patch), a variable $type is called which is no longer created because of a deletion in patch #39 at line 792 (in the patch file). Not too deep into this issue yet, hoping someone can give a pointer to what to do with this.

Status: Needs review » Needs work

The last submitted patch, 46: comment_notify-2618182-46.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

nevergone’s picture

The patch apply cleanly.

ashrafabed’s picture

Assigned: Unassigned » ashrafabed

@Silvan Wakker good catch with the $type variable:
$anonymous_problems[] = $type->link($type->label());

Like you said, the $type variable is no longer created, so that code would fail. It needs to be updated - I plan to address it in the next few days.

gnuget’s picture

Status: Needs work » Needs review
gnuget’s picture

Status: Needs review » Needs work

The last submitted patch, 51: comment_notify-2618182-rebase-46-51.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

gnuget’s picture

Ok.

This should fix the tests and a small bug that I found.

We need to finish the @todo added in the comment_notify_update_8100 function before to commit this because there are users that are using this with multiple comment fields (#3020673: False positive notifications with multiple comment types per node).

This looks great! thanks all for all work so far, I will continue working on this so we can finally commit it.

(At this point there is not even an RC version, are we sure that we want to pump this until the 8.1 version?)

gnuget’s picture

Ok, In this patch I fixed the @todo in the hook_install.

I found a small bug but I'm going to work on the weekend.

gnuget’s picture

The bug that I found was basically #46 (again) I fixed it at #2938134: Invalid placeholder (!types) in string bu the code was refactored on this patch and the problem returned.

So this time I fixed it and wrote a test so we can be sure that this is won't come back again.

I think the only thing missing is a test testing a comment notification made in a non-node entity type.

I will work on that next week.

Status: Needs review » Needs work

The last submitted patch, 56: comment_notify-2618182-56.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

gnuget’s picture

Ups, small bug.

It should be fixed in this patch.

gnuget’s picture

I wrote a test with a different entity type.

And this makes me realized that this will have some limitations, for instance the entity_terms haven't uid field, and the uid field of the users is the user id and not the user who creates the other user, this will break the Subscribe users to their entity follow-up notification emails by default option for these entity types.

I think we can create a follow-up where we add a message letting the the user know about this.

ashrafabed’s picture

@gnuget glad to see progress being made here!

I encountered that issue with uid as well (because I use this module on a custom entity type w/out uid).

The solution I was planning on is potentially providing a hook which other modules can use to replace uid with whatever is appropriate for their entity type. That's most likely out of scope here, but thought it might be worth mentioning as a possibility.

gnuget’s picture

Hi ashrafabed,

OK, sounds interesting that solution. Let's discuss it in a follow-up, thanks!

I will wait a couple days in case someone else wants to test my patch before to commit it. And if nothing went wrong I will do a new release next week.

Silvan Wakker’s picture

I'm testing this now and it does not seem to work all the times. I'm trying the following scenario's (on a custom entity):

1. Post a comment as an anonymous user (Bob), as the author I'm not getting an e-mail
2. Post a comment as author, Bob gets an email as he configured
3. Reply as the author to Bob, an email is sent to Bob
4. As Bob, post a new comment. Author is now receiving an email, but that is because he posted a comment and has configured to receive updates about all comments

Note: the default setting are "Notify me when new comments are posted" checked and "All comments". I have not touched these in any scenario.

It seems that the author of a piece of content is not receiving the author emails, the ones configured under: "Default mail subject for sending out custom_entity notifications to authors".

After typing that last sentence I realised you need to configure this setting on the user page. I'm going to leave this here for other people that might not have read INSTALL.txt and are confused. Go to user/{id}/edit and tick the box "Receive content follow-up notification e-mails".

I've performed a code review and fixed some code style violations.

P.s. a suggestion for #60: don't use hooks, use the Symfony EventDispatcher/Subscriber.

gnuget’s picture

Thanks a lot Silvan Wakker!

Accord with this there still were 3 coding standard messages.

I just fixed them.

As soon as this be green I will commit the patch.

Thanks a lot!

gnuget’s picture

  • gnuget committed 3597274 on 8.x-1.x
    Issue #2618182 by DamienMcKenna, gnuget, ashrafabed, Silvan Wakker,...
gnuget’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.