In commerce_product_pre_calculate_sell_prices() the language code is set to the empty string if the product doesn't have a language set; I think that should be LANGUAGE_NONE?

Files: 
CommentFileSizeAuthor
#4 commerce-batch_precalculate_price_language-1739600-4.patch1.78 KBAndyF
PASSED: [[SimpleTest]]: [MySQL] 3,587 pass(es).
[ View ]
#3 commerce-batch_precalculate_price_language-1739600-3.patch1.75 KBAndyF
PASSED: [[SimpleTest]]: [MySQL] 3,587 pass(es).
[ View ]
#1 commerce-batch_precalculate_price_language-1739600-1.patch886 bytesAndyF
PASSED: [[SimpleTest]]: [MySQL] 3,589 pass(es).
[ View ]

Comments

AndyF’s picture

Status:Active» Needs review
StatusFileSize
new886 bytes
PASSED: [[SimpleTest]]: [MySQL] 3,589 pass(es).
[ View ]

Thanks

rszrama’s picture

Status:Needs review» Needs work

I think what you have is correct, but we'll need an update function before we can commit this.

AndyF’s picture

Status:Needs work» Needs review
StatusFileSize
new1.75 KB
PASSED: [[SimpleTest]]: [MySQL] 3,587 pass(es).
[ View ]

Thanks, hope this is ok. I wasn't sure if the hook_update should return a message?

AndyF’s picture

StatusFileSize
new1.78 KB
PASSED: [[SimpleTest]]: [MySQL] 3,587 pass(es).
[ View ]

Oops, used the wrong table name in the comment.

rszrama’s picture

Status:Needs review» Fixed

Thanks, Andy. Committed just now. : )

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.