In commerce_product_pre_calculate_sell_prices() the language code is set to the empty string if the product doesn't have a language set; I think that should be LANGUAGE_NONE?

CommentFileSizeAuthor
#4 commerce-batch_precalculate_price_language-1739600-4.patch1.78 KBAndyF
#3 commerce-batch_precalculate_price_language-1739600-3.patch1.75 KBAndyF
#1 commerce-batch_precalculate_price_language-1739600-1.patch886 bytesAndyF
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AndyF’s picture

AndyF CreditAttribution: AndyF commented
Status: Active » Needs review
FileSize
commerce-batch_precalculate_price_language-1739600-1.patch886 bytes

Thanks

rszrama’s picture

rszrama CreditAttribution: rszrama commented
Status: Needs review » Needs work

I think what you have is correct, but we'll need an update function before we can commit this.

AndyF’s picture

AndyF CreditAttribution: AndyF commented
Status: Needs work » Needs review
FileSize
commerce-batch_precalculate_price_language-1739600-3.patch1.75 KB

Thanks, hope this is ok. I wasn't sure if the hook_update should return a message?

AndyF’s picture

AndyF CreditAttribution: AndyF commented
FileSize
commerce-batch_precalculate_price_language-1739600-4.patch1.78 KB

Oops, used the wrong table name in the comment.

rszrama’s picture

rszrama CreditAttribution: rszrama commented
Status: Needs review » Fixed

Thanks, Andy. Committed just now. : )

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.