Abstract bundle handling. [#1711648]

Coming from #661606: Support unique targets in mappers.

Generic bundle handling... Given the current architecture, it's a good idea. Each processor does basically the same thing, just a bit differently. I think it will reduce code weight, get more consistent behavior, and we could finally do some decent error handling when no bundles exist.

I would like to see FeedsProcessor split up. Feeds is not dependent on entities. I wrote a processor the other day that just sticks data into a table. I had to fake an entity type, or else re-implement a lot of code. My favorite idea would be to remove the entity bits from FeedsProcessor into a FeedsEntityProcessor. We can't do that, for backwards compatibility reasons, so I propose FeedsBaseProcessor and FeedsProcessor.

Things to do off the top of my head.

Implement FeedsProcessor::bundleType(). For the various Processors.
Implement a FeedsProcessor::bundleOptions(). A method to provide a list of available bundles for the config form.
Error handling when no bundles exist. Currently, it doesn't really exist. There shouldn't be any way to run an import without choosing a bundle.

Comments

Comment #1

twistor CreditAttribution: twistor commented 3 August 2012 at 07:51

Splitting up FeedsProcessor into 2 classes might be overkill for this issue.

Comment #2

twistor CreditAttribution: twistor commented 18 December 2012 at 17:52

Assigned:

Unassigned

» twistor

Starting this.

Comment #3

twistor CreditAttribution: twistor commented 19 December 2012 at 02:28

Assigned:	twistor	» Unassigned
Status:	Active	» Fixed

http://drupalcode.org/project/feeds.git/commit/f54cac1

We need to add a big notice to the changelog about this. Probably post a bunch of issues to other processors.

Comment #4

twistor CreditAttribution: twistor commented 19 December 2012 at 02:48

Follow-up for tests.

http://drupalcode.org/project/feeds.git/commit/e21af4c

Comment #5

scottrigby

he/him

English

Brooklyn, NY

CreditAttribution: scottrigby commented 19 December 2012 at 03:14

Excellent!
twistor++

Comment #6

2 January 2013 at 03:20

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #7

vinmassaro CreditAttribution: vinmassaro commented 16 January 2013 at 16:04

Just a heads up, I am running the 7.x-2.0-alpha7+19-dev version and I get this warning when running updates:

d7 vincentmassaro$ drush updatedb -y
The following updates are pending:

feeds module : 
  7208 -   Update to use generic bundle handling. 

Division by zero feeds.install:663                 [warning]
Performed update: feeds_update_7208                 [ok]

This code was introduced here and references this issue. Thanks.