Related we're getting the following errors in watchdog:

Warning: Invalid argument supplied for foreach() in include() (line 28 of sites/all/modules/panels/templates/panels-add-content-modal.tpl.php).
Notice: Undefined variable: columns in include() (line 28 of sites/all/modules/panels/templates/panels-add-content-modal.tpl.php).

Doing some investigation...

CommentFileSizeAuthor
#8 1708230-fix-ajax-callback.patch1.79 KBdave reid
#7 1708230-fix-ajax-callback.patch1.26 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Here's the the full export of $variables after template_process_panels_add_content_modal() has run: https://gist.github.com/b94af0642fb40614e3e9. Even if I add $vars['columns'] = array() to the begginning of template_process_panels_add_content_modal() we still get the AJAX error.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Well I'm at a loss here. :/

xeniak’s picture

xeniak commented

I'm having the same problem.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

So after some more debugging it appears that the XHProf module doesn't disable it's output on ajax callbacks.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Seems that this problem resides in Panels. Other page callbacks that use 'ajax_deliver' as the 'deliver callback' in their respective hook_menu() such as file/ajax do not have XHProf output in their JSON output.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: AJAX error when adding content to panel page » panels/ajax does not respond with the 'application/json' Content-Type header

Confirmed that a Panel AJAX response does not return the correct Content-Type header for JSON content (application/json; charset=utf-8) and therefore confuses modules like XHProf when it returns the incorrect Content-Type header of text/html.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 1708230-fix-ajax-callback.patch1.26 KB

Patch against 7.x-3.2. Let's see if it applies against 7.x-3.x.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 1708230-fix-ajax-callback.patch1.79 KB

panels_ajax_theme_callback() is unnecessary now too.

merlinofchaos’s picture

merlinofchaos commented

Committed and pushed.

It's worth noting that CTools probably also suffers from this problem, with a great deal of ajax_render() calls of its own.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Created a CTools issue: #1710710: ajax_render should not be used; ajax_deliver should be used instead.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 33c439b on 7.x-3.x, 7.x-3.x-i18n, 8.x-3.x authored by Dave Reid, committed by merlinofchaos: 
    Issue #1708230 by Dave Reid: Fixed panels/ajax does not respond with the...