Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The process of inferring a label based on item revision information is not always possible, and on scenarios that it would be liked to be used that information is usually available.
Also, the way this is implemented now is hacky, so this feature can maybe be re-introduced in the future in a clean way, but let's remove it from now?
PS: I have also a patch for versioncontrol_git that fix signature changes, but opening another issue does not make sense until this is decided.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 0001-Issue-1704548-Remove-the-idea-of-selected-label.patch | 20.64 KB | marvil07 |
| #1 | 0001-Issue-1704548-Remove-the-idea-of-selected-label.patch | 18.43 KB | marvil07 |
Comments
Comment #1
marvil07 commentedIt would be great to receive a quick review on this before pushing.
Comment #2
marvil07 commentedAnd I forgot to change the relevant interface!
Comment #3
marvil07 commentedTagging and adding to the stable release roadmap.
Comment #4
sdboyer commentedhow much of a review are you looking for? i can say that i agree with removing this concept, but i can't say much about whether or not you've gotten all of the pieces out.
the tests pass, which is what's primarily important, but honestly, i barely even remembered that we HAD this system. i have no problem with ripping it out, but i have no idea how many pieces there all are. if you think you've gotten them all, and the tests pass, that's good enough for me.
Comment #5
marvil07 commentedI was mainly asking on agreement on the idea, so I see we agree. It made some sense when operation represented something between commit and event, but now that it's decoupled, it worths to remove it.
Yes, it's old code, and yes I think it's all the pieces to change inside the project.
It needs to change one interface, so we need to change also all external code using that. I will take care of git backend too, next we need to change drupalorg if it implements a custom webviewer plugin too.
Added to D7.
Comment #6
marvil07 commentedBackported to D6, also on git backend(sorry, too late to open just another issue).
What's missing:
Comment #7
marvil07 commentedAnd change notification is there: http://drupal.org/node/1720124
So, the missing part is: