I have a website where the website maintainers have created 75 page variants and can not reorder them due to the delta limit being set to 30.

Thoughts/recommendations on having that many page variants?

I see where the delta was increased to 30 from 10 but why was 30 chosen as opposed to a larger number?

CommentFileSizeAuthor
#8 ctools-n1700378-8.patch972 bytesdamienmckenna
#7 ctools-page_manager_dynamic_variant_delta-1700378-7.patch907 byteslogickal
#6 ctools-page_manager_dynamic_variant_delta-1700378-6.patch889 byteslogickal
#4 page_manager_dynamic_variant_delta-1700378-4.patch782 byteslogickal
#2 delta_reorder_and_number_of_page_variants-1700378-2.patch1.11 KBdimduj

Comments

dimduj’s picture

dimduj commented

I can provide a patch

dimduj’s picture

dimduj commented
Status: Active » Needs review
StatusFileSize
new delta_reorder_and_number_of_page_variants-1700378-2.patch1.11 KB

Here is the patch for the 6.x-1.x branch.

This is related to
http://drupal.org/node/293370
http://drupal.org/node/589440

But can be fixed easilly due to the fact that variant hasn't to handle hierarchy .

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 6.x-1.7 » 7.x-1.x-dev
Issue summary: View changes
Status: Needs review » Patch (to be ported)

This affects the D7 branch too.

logickal’s picture

logickal commented
StatusFileSize
new page_manager_dynamic_variant_delta-1700378-4.patch782 bytes

Re-rolled against 7.x-1.x-dev.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Patch (to be ported) » Needs review
logickal’s picture

logickal commented
StatusFileSize
new ctools-page_manager_dynamic_variant_delta-1700378-6.patch889 bytes

Adding a comment to describe how the patch is handling the #delta parameter.

logickal’s picture

logickal commented
StatusFileSize
new ctools-page_manager_dynamic_variant_delta-1700378-7.patch907 bytes

Better commenting.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new ctools-n1700378-8.patch972 bytes

I wasn't able to apply the patch, it was complaining about "malformed patch at line 14", so I've rerolled it.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Reviewed & tested by the community

This seems to fix the problem.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2554511: Plan for CTools 7.x-1.10 release

This is a small fix and would be worth adding to the next release.

mustanggb’s picture

mustanggb commented
Parent issue: #2554511: Plan for CTools 7.x-1.10 release » #2554339: Plan for CTools 7.x-1.10 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2554339: Plan for CTools 7.x-1.10 release » #2785697: Plan for CTools 7.x-1.11 release

This wasn't added to 7.x-1.10, bumping it to 7.x-1.11.

rivimey’s picture

rivimey
she/her
commented
Issue tags: +Dublin2016

Patch in #8 applies cleanly to 7.x-1.x.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Looks good. fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jastraat’s picture

jastraat commented
Related issues: +#2836195: Regression: Page Variant weight from features overridden