This notice is currently showing up when the admin views tests are run, I think we just need to make sure we turn on the taxonomy module for our tests?

Comments

sun’s picture

Last time I ran the tests, that was a debug() though, not a PHP notice -- is that no longer the case?

If it's still a debug(), then I'd rather ignore it. We can add the dependency on taxonomy when we'll get that taxonomy view to work... ;)

damiankloip’s picture

Status: Needs review » Postponed

Sorry, wasn't clear. Yes, they are debug() messages. Fair enough, lets postpone it then :)

mvc’s picture

Issue summary: View changes
StatusFileSize
new382 bytes

this actually spits out various warning messages when editing the view admin_views_node as well:

Missing handler: taxonomy_term_data vid filter
Missing handler: node term_node_tid relationship
Missing handler: taxonomy_term_data vid filter
Missing handler: node term_node_tid relationship
Missing handler: node term_node_tid relationship

the problem is that taxonomy is not declared as a dependency of this module. i just came across this while testing something else on a site using the minimal install profile, which doesn't enable the taxonomy module.

trivial patch attached.

mvc’s picture

Title: Test notices: 'Missing handler: node term_node_tid relationship' » Missing handler: node term_node_tid relationship
Status: Postponed » Needs review

changing the title & status since i reproduced this outside the test suite.

damiankloip’s picture

I am thinking I may rather just remove the view altogether. It is not useful and is not likely to be any time soon.

mvc’s picture

@damiankloip: um, am i missing something here? you don't think the admin_views_node view is useful? isn't that what this project is for?

hmm, perhaps you just meant the vocabulary filter? in that case, no objection here.

damiankloip’s picture

Yes. Of course the taxonomy one. You know, the one that doesn't really work or do anything :)

I'll remove it.

damienmckenna’s picture

Status: Needs review » Reviewed & tested by the community

Yes, because of the way the bundled views are constructed, the Taxonomy module is required.

damienmckenna’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new3.7 KB

Alternatively, how about only loading the relationship and filter if the Taxonomy module is enabled?

Stevel’s picture

Status: Needs review » Reviewed & tested by the community

I like this method better, since it allows the admin_views to be used without taxonomy needing to be enabled.

I tested the patch and the notices disappeared from the tests, so I suppose they are gone from the UI as well.

chris matthews’s picture

  • DamienMcKenna committed 2b2e740 on 7.x-1.x
    Issue #1698784 by damiankloip, mvc, DamienMcKenna, Stevel, sun: Missing...
damienmckenna’s picture

Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.