This notice is currently showing up when the admin views tests are run, I think we just need to make sure we turn on the taxonomy module for our tests?
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | admin_views-n1698784-9.patch | 3.7 KB | damienmckenna |
| #3 | admin_views-1698784-3-require-taxonomy.patch | 382 bytes | mvc |
| admin_views.test-notice.patch | 470 bytes | damiankloip |
Comments
Comment #1
sunLast time I ran the tests, that was a debug() though, not a PHP notice -- is that no longer the case?
If it's still a debug(), then I'd rather ignore it. We can add the dependency on taxonomy when we'll get that taxonomy view to work... ;)
Comment #2
damiankloip commentedSorry, wasn't clear. Yes, they are debug() messages. Fair enough, lets postpone it then :)
Comment #3
mvcthis actually spits out various warning messages when editing the view admin_views_node as well:
Missing handler: taxonomy_term_data vid filter
Missing handler: node term_node_tid relationship
Missing handler: taxonomy_term_data vid filter
Missing handler: node term_node_tid relationship
Missing handler: node term_node_tid relationship
the problem is that taxonomy is not declared as a dependency of this module. i just came across this while testing something else on a site using the minimal install profile, which doesn't enable the taxonomy module.
trivial patch attached.
Comment #4
mvcchanging the title & status since i reproduced this outside the test suite.
Comment #5
damiankloip commentedI am thinking I may rather just remove the view altogether. It is not useful and is not likely to be any time soon.
Comment #6
mvc@damiankloip: um, am i missing something here? you don't think the admin_views_node view is useful? isn't that what this project is for?
hmm, perhaps you just meant the vocabulary filter? in that case, no objection here.
Comment #7
damiankloip commentedYes. Of course the taxonomy one. You know, the one that doesn't really work or do anything :)
I'll remove it.
Comment #8
damienmckennaYes, because of the way the bundled views are constructed, the Taxonomy module is required.
Comment #9
damienmckennaAlternatively, how about only loading the relationship and filter if the Taxonomy module is enabled?
Comment #10
Stevel commentedI like this method better, since it allows the admin_views to be used without taxonomy needing to be enabled.
I tested the patch and the notices disappeared from the tests, so I suppose they are gone from the UI as well.
Comment #11
chris matthews commentedComment #13
damienmckennaCommitted. Thanks.