Problem

  • In edge-cases, error/exception assertions may be triggered and attempted to be inserted when the child site (under test) has not been set up yet.
CommentFileSizeAuthor
#14 drupal7-test_connection-1679570-14.patch2.22 KBmgifford
#7 drupal7-test_connection-1679570-7.patch2.21 KBlucascaro
drupal8.test-connection.0.patch2.17 KBsun

Comments

lucascaro’s picture

lucascaro commented

seems legit

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix, +Needs backport to D7

I guess you forgot to change the status? ;)

lucascaro’s picture

lucascaro commented

indeed!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: -Quick fix, -Needs backport to D7, -Testing system

drupal8.test-connection.0.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: +Quick fix, +Needs backport to D7, +Testing system

drupal8.test-connection.0.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

This looks fine, just a helper and then actually using the same logic everywhere. Committed/pushed to 8.x, moving to 7.x for backport.

lucascaro’s picture

lucascaro commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new drupal7-test_connection-1679570-7.patch2.21 KB

Here's a direct port for D7

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Thanks for the backport! Looks ready to go for me.

However, not marking as RTBC yet, since I want to prevent potential commit conflicts with #1563620: All unit tests blow up with a fatal error

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Assigned: sun » Unassigned
mgifford’s picture

mgifford
he/him
Primary language English
commented

7: drupal7-test_connection-1679570-7.patch queued for re-testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes

Well, #1563620: All unit tests blow up with a fatal error is in, so should be RTBC now if there are no conflicts, right?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Yes, I think it would be helpful to backport this, as it syncs part of the functional code.

However, the backport patch contains an phpDoc indentation error:

   /**
+  * Returns the database connection to the site running Simpletest.
...
+  */
+  public static function getDatabaseConnection() {
mgifford’s picture

mgifford
he/him
Primary language English
commented

Sorry. I looked but still don't see the phpDoc indentation. Other than that though you'd see this as RTBC?

mgifford’s picture

mgifford
he/him
Primary language English
commented
StatusFileSize
new drupal7-test_connection-1679570-14.patch2.22 KB

Totally missed that space @sun. Had to get @mparker17 to point it out to me.

Think this gets it.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: drupal7-test_connection-1679570-14.patch, failed testing.

Status: Needs work » Needs review

cs_shadow queued 14: drupal7-test_connection-1679570-14.patch for re-testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

bad bot.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: drupal7-test_connection-1679570-14.patch, failed testing.

Status: Needs work » Needs review

mgifford queued 14: drupal7-test_connection-1679570-14.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: drupal7-test_connection-1679570-14.patch, failed testing.

Status: Needs work » Needs review

dcam queued 14: drupal7-test_connection-1679570-14.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: drupal7-test_connection-1679570-14.patch, failed testing.

Status: Needs work » Needs review

dcam queued 14: drupal7-test_connection-1679570-14.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: drupal7-test_connection-1679570-14.patch, failed testing.

Status: Needs work » Needs review

dcam queued 14: drupal7-test_connection-1679570-14.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: drupal7-test_connection-1679570-14.patch, failed testing.

Status: Needs work » Needs review

dcam queued 14: drupal7-test_connection-1679570-14.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: drupal7-test_connection-1679570-14.patch, failed testing.

Status: Needs work » Needs review

mgifford queued 14: drupal7-test_connection-1679570-14.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: drupal7-test_connection-1679570-14.patch, failed testing.

Status: Needs work » Needs review

mgifford queued 14: drupal7-test_connection-1679570-14.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed 90d6f05 on 7.x 
    Issue #1679570 by mgifford, lucascaro, sun: Fixed TestBase does not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.